feat(cactus-plugin-persistence-ethereum): use openapi ethereum connector #2749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
outSH
requested review from
petermetz,
takeutak,
izuru0,
jagpreetsinghsasan,
VRamakrishna and
sandeepnRES
as code owners
outSH
changed the title
|
This PR/issue depends on:
|
- Refactor persistence ethereum plugin to use openapi ethereum connector
instead of ethereum-socketio.
- Upgrade web3js to 4.X in both persistence plugin and its tests.
- Update persistence plugin dependency list.
- Recompile base token contracts in persistence plugin to match format
required by ethereum connector (full compilation output, not just ABI)
- Minor fix in ethereum connector to return empty transactions
array instead of undefined.
- Fix minor runtime issues in geth-test-ledger
Depends on hyperledger-cacti#2631
Signed-off-by: Michal Bajer <[email protected]>
outSH
force-pushed
the
use_openapi_ethereum_in_persistence_plugin
branch
from
aa2e8f8
to
cbd5d92
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
instead of ethereum-socketio.
required by ethereum connector (full compilation output, not just ABI)
array instead of undefined.
Depends on #2631
Signed-off-by: Michal Bajer [email protected]