-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cactus-example-discounted-asset-trade): use openapi ethereum connector #2723
feat(cactus-example-discounted-asset-trade): use openapi ethereum connector #2723
Conversation
️✅ There are no secrets present in this pull request anymore.If these secrets were true positive and are still valid, we highly recommend you to revoke them. 🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@outSH There's only one parent PR but 4 commits. Does this need a rebase + squash?
The one commit that matches the PR title is looking good otherwise.
@petermetz These are commits from dependencies of the dependency |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@outSH /facepalm - sorry, I should've known/checked/etc. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@outSH Looks good but please pass it back for review once the parent PR(s) have been merged and the conflicts have been resolved! (I'm just marking it down as a change request to not forget that I have to take a second pass on it once it reached it's final state)
5e45a2d
to
d6aa5a1
Compare
@petermetz
|
…nector - Refactor discounted asset trade sample to use openapi ethereum connector instead of ethereum-socketio. - Use eth signing utils from ethereum connector package. - Fix nodejs setup in indy-sdk-cli docker image. - Small fixes after recent ethereum connector refactors. Depends on: hyperledger-cacti#2645 Signed-off-by: Michal Bajer <[email protected]>
d6aa5a1
to
3b48876
Compare
@outSH Gotcha, LGTM, thank you for the updates! |
instead of ethereum-socketio.
Depends on: #2645
Signed-off-by: Michal Bajer [email protected]