Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(tools/docker/indy-sdk-cli): fix deprecation deb.nodesource.com/setup_16.x #2706

Merged
merged 1 commit into from
Oct 13, 2023

Commits on Oct 13, 2023

  1. build(tools/docker/indy-sdk-cli): fix deprecation deb.nodesource.com/…

    …setup_16.x
    
    **Primary Change:**
    
    In the Dockerfile, the issue related to NodeJS was addressed by
    updating the NodeJS installation method to use the new NodeSource
    installation method. The previous method using
    `curl -sL https://deb.nodesource.com/setup_16.x | bash -`
    had become deprecated, so the new method was applied for compatibility
    with the latest practices.
    
    The specific changes made in the Dockerfile are as follows:
    
    1. Removed the old installation method for NodeJS:
    
       ```Dockerfile
       # Removed the deprecated NodeJS installation method
       # RUN curl -sL https://deb.nodesource.com/setup_16.x | bash -
       ```
    
    2. Added the new NodeSource installation method:
    
    ```Dockerfile
    RUN curl -fsSL https://deb.nodesource.com/gpgkey/nodesource-repo.gpg.key | \
            gpg --dearmor -o /usr/share/keyrings/nodesource-archive-keyring.gpg \
        && echo "deb [arch=amd64 signed-by=/usr/share/keyrings/nodesource-archive-keyring.gpg] \
        https://deb.nodesource.com/node bionic main" | \
        tee /etc/apt/sources.list.d/nodesource.list
    ```
    
    [skip ci]
    
    Co-authored-by: Peter Somogyvari <[email protected]>
    
    Signed-off-by: urvish667 <[email protected]>
    Signed-off-by: Peter Somogyvari <[email protected]>
    urvish667 authored and petermetz committed Oct 13, 2023
    Configuration menu
    Copy the full SHA
    4cf4cbb View commit details
    Browse the repository at this point in the history