Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): upgrade web3js-quorum to v22.4.0 #2649

Merged
merged 1 commit into from
Sep 6, 2023

Conversation

petermetz
Copy link
Contributor

Upgraded to v22.4.0 but did not yet delete our hand-built typings
because the ones that v22.4.0 ships with are broken (do not match the
actual implementation forcing programmers to fight the compiler
needlessly)

Fixes #2648

Signed-off-by: Peter Somogyvari [email protected]

Copy link
Contributor

@izuru0 izuru0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@jagpreetsinghsasan jagpreetsinghsasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Upgraded to v22.4.0 but did not yet delete our hand-built typings
because the ones that v22.4.0 ships with are broken (do not match the
actual implementation forcing programmers to fight the compiler
needlessly)

Fixes hyperledger-cacti#2648

Signed-off-by: Peter Somogyvari <[email protected]>
@petermetz petermetz merged commit 9ef4cf0 into hyperledger-cacti:main Sep 6, 2023
120 of 132 checks passed
@petermetz petermetz deleted the petermetz/issue2648 branch September 6, 2023 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

build(deps): upgrade web3js-quorum to v22.4.0
3 participants