test(ghcr-rust-compiler): fix image build - anstream v0.5.0 cannot be built #2643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petermetz
requested review from
takeutak,
izuru0,
jagpreetsinghsasan,
VRamakrishna and
sandeepnRES
as code owners
jagpreetsinghsasan
approved these changes
Aug 29, 2023
takeutak
approved these changes
Aug 29, 2023
… built 1. Upgraded the rust version of the image to v1.72.0 - short term fix 2. The longer term fix is that I locked down the version of wasm-pack to the current latest stable (v0.12.1) so that the auto-upgrade doesn't bite is again like this where the newer wasm-pack starts demanding a newer rust compiler which we don't have because we are pinning to a specific version through the image tag that's being used. Fixes hyperledger-cacti#2641 Signed-off-by: Peter Somogyvari <[email protected]>
petermetz
force-pushed
the
petermetz/issue2641
branch
from
2a56638
to
b3f0da5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the current latest stable (v0.12.1) so that the auto-upgrade
doesn't bite is again like this where the newer wasm-pack
starts demanding a newer rust compiler which we don't
have because we are pinning to a specific version through
the image tag that's being used.
Fixes #2641
Signed-off-by: Peter Somogyvari [email protected]