-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(weaver): corda asset transfer test workflow added and bug fixes #2438
Conversation
sandeepnRES
commented
May 30, 2023
•
edited
Loading
edited
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ccbef58
to
b8526d7
Compare
b9d256b
to
f323a50
Compare
|
GitGuardian id | Secret | Commit | Filename | |
---|---|---|---|---|
- | Generic CLI Secret | fe5186e | weaver/samples/fabric/fabric-cli/scripts/createUsers.sh | View secret |
- | Generic CLI Secret | fe5186e | weaver/samples/fabric/fabric-cli/scripts/createUsers.sh | View secret |
- | Generic CLI Secret | fe5186e | weaver/samples/fabric/fabric-cli/scripts/initAsset.sh | View secret |
- | Generic CLI Secret | fe5186e | weaver/samples/fabric/fabric-cli/scripts/initAsset.sh | View secret |
- | Generic CLI Secret | fe5186e | weaver/samples/fabric/fabric-cli/scripts/initAssetN1.sh | View secret |
- | Generic CLI Secret | fe5186e | weaver/samples/fabric/fabric-cli/scripts/initAssetsForTransfer.sh | View secret |
- | Generic Private Key | fe5186e | weaver/samples/fabric/fabric-cli/src/wallet-network1/alice.id | View secret |
- | Generic Private Key | fe5186e | weaver/samples/fabric/fabric-cli/src/wallet-network1/bob.id | View secret |
- | Generic Private Key | fe5186e | weaver/samples/fabric/fabric-cli/src/wallet-network2/alice.id | View secret |
- | Generic Private Key | fe5186e | weaver/samples/fabric/fabric-cli/src/wallet-network2/bob.id | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Our GitHub checks need improvements? Share your feedbacks!
These are all sample keys for testing purposes, am adding those paths to ignore-paths for git-guardian |
- fix(weaver): corda asset transfer bug fix with decoding interop payload - fix(corda-driver): dockerfile build bug - fix(corda-sdk): fix bug with logs and error messages - fix(weaver): update alice and bob cert for asset transfer - fix(corda): simpleapp initialize ledger dynamically based on number of nodes - fix(sdk): increase default timeout for interopFlow - feat(ci): add debug logs to data sharing and asset transfer - chore(testnet): check-in alice and bob certs for fabric networks Signed-off-by: Sandeep Nishad <[email protected]>