Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: fix release automation #2180

Merged
merged 1 commit into from
Nov 2, 2022

Conversation

petermetz
Copy link
Contributor

Adds a GitHub workflow yaml file that executes the
publish script.
This workflow only gets triggered when a git tag has been
created that starts with the letter v (as in version).

Fixes #1951
Fixes #2054
Fixes #2175

Signed-off-by: Peter Somogyvari [email protected]

@takeutak
Copy link
Contributor

takeutak commented Nov 1, 2022

@petermetz I appproved this pull-request, but let me confirm your intention.
In my understanding, your changes mean that you want to execute the workflow only if the version tag (e.g. "v1.1.0") is created (to reduce the work of CI), is it right?

Adds a GitHub workflow yaml file that executes the
publish script.
This workflow only gets triggered when a git tag has been
created that starts with the letter v (as in version).

Fixes hyperledger-cacti#1951
Fixes hyperledger-cacti#2054
Fixes hyperledger-cacti#2175

Signed-off-by: Peter Somogyvari <[email protected]>
@petermetz
Copy link
Contributor Author

@petermetz I appproved this pull-request, but let me confirm your intention. In my understanding, your changes mean that you want to execute the workflow only if the version tag (e.g. "v1.1.0") is created (to reduce the work of CI), is it right?

@takeutak Thank you for the review! Yes, this is correct all correct. In addition to reducing load on the CI we also have to limit auto-publishing packages this way (instead of auto-publishing for each pull-request & commit on the main branch) because there are limits on how many versions packages can have both on npm and on the github package manager. I don't remember the exact numbers but back when I read up on the limits they were around a thousand versions per package meaning that if I let the CI auto-publish on every commit of the main branch then we'd hit the version limit and would have to start deleting older versions of the package manually as we add new commits to main. So the middle ground I choose is that we can manually control when we auto-publish based on tagging commits on the main branch.

@petermetz petermetz merged commit 2fec226 into hyperledger-cacti:main Nov 2, 2022
@petermetz petermetz deleted the petermetz/issue2175 branch November 2, 2022 20:28
@petermetz
Copy link
Contributor Author

Well, it did not work out the way I thought it would so now here's the follow-up: #2186

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants