Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(cmd-api-server): jestify jwt-socketio-endpoint-authorization.test #1988

Merged

Conversation

Leeyoungone
Copy link
Contributor

@Leeyoungone Leeyoungone commented Apr 25, 2022

packages/cactus-cmd-api-server/src/test/typescript/integration/jwt-socketio-endpoint-authorization.test.ts;

@petermetz petermetz self-assigned this Aug 14, 2023
@petermetz petermetz force-pushed the jwt-socketio-endpoint-auth-test branch from c1eb700 to 3c79fa1 Compare August 14, 2023 22:33
Copy link
Contributor

@petermetz petermetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed the bug in the test case (race condition) - LGTM

@petermetz petermetz marked this pull request as ready for review August 14, 2023 22:34
@petermetz petermetz self-requested a review August 14, 2023 22:34
@petermetz petermetz enabled auto-merge (rebase) August 14, 2023 22:34
@petermetz petermetz changed the title test: jestify jwt socketio endpoint authorization test(cmd-api-server): jestify jwt-socketio-endpoint-authorization.test Aug 14, 2023
@jagpreetsinghsasan
Copy link
Contributor

LGTM

@petermetz petermetz force-pushed the jwt-socketio-endpoint-auth-test branch from 3c79fa1 to caa79f6 Compare August 18, 2023 21:18
@petermetz petermetz force-pushed the jwt-socketio-endpoint-auth-test branch from caa79f6 to 59b6358 Compare August 18, 2023 22:55
@petermetz petermetz merged commit b218bf7 into hyperledger-cacti:main Aug 18, 2023
107 of 117 checks passed
@petermetz petermetz deleted the jwt-socketio-endpoint-auth-test branch August 18, 2023 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants