Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(cactus-plugin-ledger-connector-corda): remove unused openapi.yaml #3200

Closed
aldousalvarez opened this issue Apr 11, 2024 · 0 comments · Fixed by #3201
Closed

chore(cactus-plugin-ledger-connector-corda): remove unused openapi.yaml #3200

aldousalvarez opened this issue Apr 11, 2024 · 0 comments · Fixed by #3201
Assignees
@aldousalvarez

Comments

@aldousalvarez
Copy link
Contributor

Description

After working on updating the OpenAPI extension there was one openapi.yaml on plugin-ledger-connector-corda that still has x-hyperledger-cactus. When I tried to update it manually, Peter mentioned that it should automatically update after running the generate-server script on package.json. So after further investigation I have found that this openapi.yaml is already irrelevant to the plugin-ledger-connector-corda. I have verified this since we added "documentationProvider: none" on packages/cactus-plugin-ledger-connector-corda/src/main-server/openapi-generator-config.yaml the openapi.yaml does not get updated if we run the generate-server script. As you can also see the changes on this issue #2662 one of the changes is openapi.yaml is removed from the packages/cactus-plugin-ledger-connector-corda/src/main-server/kotlin/gen/kotlin-spring/.openapi-generator/FILES since it is not being used since documentationProvider: none is now implemented.
aldousalvarez added a commit to aldousalvarez/cactus that referenced this issue Apr 11, 2024
@aldousalvarez
chore(cactus-plugin-ledger-connector-corda): remove unused openapi.yaml
6523f73 
Primary Changes
----------------
1. Removed the unused openapi.yaml in plugin-ledgerconnector-corda

Fixes hyperledger-cacti#3200

Signed-off-by: aldousalvarez <[email protected]>
@aldousalvarez aldousalvarez mentioned this issue Apr 11, 2024
Merged
5 tasks
aldousalvarez added a commit to aldousalvarez/cactus that referenced this issue Apr 11, 2024
@aldousalvarez
chore(cactus-plugin-ledger-connector-corda): remove unused openapi.yaml
8e3f3aa 
Primary Changes
----------------
1. Removed the unused openapi.yaml in plugin-ledger-connector-corda

Fixes hyperledger-cacti#3200

Signed-off-by: aldousalvarez <[email protected]>
petermetz pushed a commit to aldousalvarez/cactus that referenced this issue May 18, 2024
@aldousalvarez @petermetz
chore(cactus-plugin-ledger-connector-corda): remove unused openapi.yaml
64bcf69 
Primary Changes
----------------
1. Removed the unused openapi.yaml in plugin-ledger-connector-corda

Fixes hyperledger-cacti#3200

Signed-off-by: aldousalvarez <[email protected]>
outSH pushed a commit that referenced this issue May 18, 2024
@aldousalvarez @outSH
chore(cactus-plugin-ledger-connector-corda): remove unused openapi.yaml
710463c 
Primary Changes
----------------
1. Removed the unused openapi.yaml in plugin-ledger-connector-corda

Fixes #3200

Signed-off-by: aldousalvarez <[email protected]>
sandeepnRES pushed a commit to sandeepnRES/cacti that referenced this issue Jul 30, 2024
@aldousalvarez @sandeepnRES
chore(cactus-plugin-ledger-connector-corda): remove unused openapi.yaml
7c3f2dd 
Primary Changes
----------------
1. Removed the unused openapi.yaml in plugin-ledger-connector-corda

Fixes hyperledger-cacti#3200

Signed-off-by: aldousalvarez <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aldousalvarez aldousalvarez

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(cactus-plugin-ledger-connector-corda): remove unused openapi.yaml aldousalvarez/cactus
1 participant
@aldousalvarez