Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(deps): upgrade Jest to v29.6.2 project-wide #2606

Closed
petermetz opened this issue Aug 12, 2023 · 0 comments · Fixed by #2607
Closed

build(deps): upgrade Jest to v29.6.2 project-wide #2606

petermetz opened this issue Aug 12, 2023 · 0 comments · Fixed by #2607
Assignees
@petermetz
Labels
dependencies Pull requests that update a dependency file Developer_Experience P1 Priority 1: Highest Performance Everything related to how fast/efficient the software or it's tooling (e.g. build) is. Security Related to existing or potential security vulnerabilities
Milestone
v2.0.0-alpha.2

Comments

@petermetz
Copy link
Contributor

petermetz commented Aug 12, 2023 •
edited
Loading

Also upgrade the @types/jest pacakge at the same time so that the typings
are consistent with the new version of the code being used by the tests.

The reason why we need to upgrade jest is because older versions have vulnerable [1]
versions of ansi-regex declared as transitive dependencies.

[1] https://github.com/hyperledger/cacti/security/dependabot/122

why-ansi-regex.log
@petermetz petermetz added dependencies Pull requests that update a dependency file Developer_Experience P1 Priority 1: Highest Performance Everything related to how fast/efficient the software or it's tooling (e.g. build) is. Security Related to existing or potential security vulnerabilities labels Aug 12, 2023
@petermetz petermetz self-assigned this Aug 12, 2023
@petermetz petermetz changed the title build(deps): upgrade Jest to v29.5.3 project-wide build(deps): upgrade Jest to v29.6.2 project-wide Aug 12, 2023
@petermetz petermetz added this to the v2.0.0-alpha.2 milestone Aug 12, 2023
petermetz added a commit to petermetz/cacti that referenced this issue Aug 12, 2023
@petermetz
build(deps): upgrade Jest to v29.6.2 project-wide
2bee1f1 
Also upgraded these packages to make sure that
they all work correctly together:
1. @types/jest
2. jest-extended
3. ts-jest

Also disabled build scripts for nodemon which was
crashing during yarn install.

Fixes hyperledger-cacti#2606

Signed-off-by: Peter Somogyvari <[email protected]>
This was referenced Aug 12, 2023
Closed
Merged
petermetz added a commit to petermetz/cacti that referenced this issue Aug 17, 2023
@petermetz
build(deps): upgrade Jest to v29.6.2 project-wide
716bbe4 
Also upgraded these packages to make sure that
they all work correctly together:
1. @types/jest
2. jest-extended
3. ts-jest

Also disabled build scripts for nodemon which was
crashing during yarn install.

Fixes hyperledger-cacti#2606

Signed-off-by: Peter Somogyvari <[email protected]>
petermetz added a commit to petermetz/cacti that referenced this issue Aug 17, 2023
@petermetz
build(deps): upgrade Jest to v29.6.2 project-wide
9a76f19 
Also upgraded these packages to make sure that
they all work correctly together:
1. @types/jest
2. jest-extended
3. ts-jest

Also disabled build scripts for nodemon which was
crashing during yarn install.

Fixes hyperledger-cacti#2606

Signed-off-by: Peter Somogyvari <[email protected]>
petermetz added a commit to petermetz/cacti that referenced this issue Aug 17, 2023
@petermetz
build(deps): upgrade Jest to v29.6.2 project-wide
7d54fd5 
Also upgraded these packages to make sure that
they all work correctly together:
1. @types/jest
2. jest-extended
3. ts-jest

Also disabled build scripts for nodemon which was
crashing during yarn install.

Fixes hyperledger-cacti#2606

Signed-off-by: Peter Somogyvari <[email protected]>
petermetz added a commit to petermetz/cacti that referenced this issue Aug 17, 2023
@petermetz
build(deps): upgrade Jest to v29.6.2 project-wide
daf7cfb 
Also upgraded these packages to make sure that
they all work correctly together:
1. @types/jest
2. jest-extended
3. ts-jest

Also disabled build scripts for nodemon which was
crashing during yarn install.

Fixes hyperledger-cacti#2606

Signed-off-by: Peter Somogyvari <[email protected]>
petermetz added a commit that referenced this issue Aug 17, 2023
@petermetz
build(deps): upgrade Jest to v29.6.2 project-wide
7f45341 
Also upgraded these packages to make sure that
they all work correctly together:
1. @types/jest
2. jest-extended
3. ts-jest

Also disabled build scripts for nodemon which was
crashing during yarn install.

Fixes #2606

Signed-off-by: Peter Somogyvari <[email protected]>
sandeepnRES pushed a commit to sandeepnRES/cacti that referenced this issue Dec 21, 2023
@petermetz @sandeepnRES
build(deps): upgrade Jest to v29.6.2 project-wide
3577ebc 
Also upgraded these packages to make sure that
they all work correctly together:
1. @types/jest
2. jest-extended
3. ts-jest

Also disabled build scripts for nodemon which was
crashing during yarn install.

Fixes hyperledger-cacti#2606

Signed-off-by: Peter Somogyvari <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@petermetz petermetz

Labels
dependencies Pull requests that update a dependency file Developer_Experience P1 Priority 1: Highest Performance Everything related to how fast/efficient the software or it's tooling (e.g. build) is. Security Related to existing or potential security vulnerabilities
Projects
None yet
Milestone
v2.0.0-alpha.2
1 participant
@petermetz