ci(custom-checks): fix sibling pkg dependency version inconsistencies #2431
Assignees
Labels
bug
Something isn't working
dependencies
Pull requests that update a dependency file
Developer_Experience
good-first-issue
Good for newcomers
good-first-issue-100-introductory
Hacktoberfest
Hacktoberfest participants are welcome to take a stab at issues marked with this label.
P2
Priority 2: High
Comments
|
@rwat17 Thank you for reporting! This is indeed a bug, the versions should be consistent across the framework codebase! TLDR: Yes, please send a PR with making the versions consistent (or let me know if you'd prefer to not work on it and we'll get it done) |
petermetz
added
P2
|
@petermetz will do this in the meantime today :) |
rwat17
added a commit
to rwat17/cactus
that referenced
this issue
Jun 14, 2023
Closes: hyperledger-cacti#2431 Signed-off-by: Tomasz Awramski <[email protected]>
rwat17
added a commit
to rwat17/cactus
that referenced
this issue
Jun 14, 2023
Closes: hyperledger-cacti#2431 Signed-off-by: Tomasz Awramski <[email protected]>
sandeepnRES
pushed a commit
to rwat17/cactus
that referenced
this issue
Jun 15, 2023
Closes: hyperledger-cacti#2431 Signed-off-by: Tomasz Awramski <[email protected]>
sandeepnRES
pushed a commit
to rwat17/cactus
that referenced
this issue
Jun 16, 2023
Closes: hyperledger-cacti#2431 Signed-off-by: Tomasz Awramski <[email protected]>
petermetz
changed the title
petermetz
pushed a commit
to rwat17/cactus
that referenced
this issue
Jun 17, 2023
I also snuck in a couple of additional changes in the interest of speeding up CI execution as soon as possible. Apologies for the intrusion! - Peter Somogyvari The additional changes are: 1. Comment out (e.g. disable) the odap-hermes plugin's tests for now since they are completely broken anyway and just wasting CI resources. 2. Fixed a logging bug in the custom-checks .ts script 3. Modified the ci.sh file (the workhorse of the CI) so that it does run the custom-checks as part of it. This was made possible by the change that this commit is originally intended to do (e.g., without this change the custom checks would fail but now they pass) Closes: hyperledger-cacti#2431 Co-authored-by: Peter Somogyvari <[email protected]> Signed-off-by: Peter Somogyvari <[email protected]> Signed-off-by: Tomasz Awramski <[email protected]>
sandeepnRES
pushed a commit
that referenced
this issue
Jun 17, 2023
I also snuck in a couple of additional changes in the interest of speeding up CI execution as soon as possible. Apologies for the intrusion! - Peter Somogyvari The additional changes are: 1. Comment out (e.g. disable) the odap-hermes plugin's tests for now since they are completely broken anyway and just wasting CI resources. 2. Fixed a logging bug in the custom-checks .ts script 3. Modified the ci.sh file (the workhorse of the CI) so that it does run the custom-checks as part of it. This was made possible by the change that this commit is originally intended to do (e.g., without this change the custom checks would fail but now they pass) Closes: #2431 Co-authored-by: Peter Somogyvari <[email protected]> Signed-off-by: Peter Somogyvari <[email protected]> Signed-off-by: Tomasz Awramski <[email protected]>
barnapa
pushed a commit
to barnapa/cacti
that referenced
this issue
Jun 22, 2023
I also snuck in a couple of additional changes in the interest of speeding up CI execution as soon as possible. Apologies for the intrusion! - Peter Somogyvari The additional changes are: 1. Comment out (e.g. disable) the odap-hermes plugin's tests for now since they are completely broken anyway and just wasting CI resources. 2. Fixed a logging bug in the custom-checks .ts script 3. Modified the ci.sh file (the workhorse of the CI) so that it does run the custom-checks as part of it. This was made possible by the change that this commit is originally intended to do (e.g., without this change the custom checks would fail but now they pass) Closes: hyperledger-cacti#2431 Co-authored-by: Peter Somogyvari <[email protected]> Signed-off-by: Peter Somogyvari <[email protected]> Signed-off-by: Tomasz Awramski <[email protected]>
sandeepnRES
pushed a commit
to sandeepnRES/cacti
that referenced
this issue
Dec 21, 2023
I also snuck in a couple of additional changes in the interest of speeding up CI execution as soon as possible. Apologies for the intrusion! - Peter Somogyvari The additional changes are: 1. Comment out (e.g. disable) the odap-hermes plugin's tests for now since they are completely broken anyway and just wasting CI resources. 2. Fixed a logging bug in the custom-checks .ts script 3. Modified the ci.sh file (the workhorse of the CI) so that it does run the custom-checks as part of it. This was made possible by the change that this commit is originally intended to do (e.g., without this change the custom checks would fail but now they pass) Closes: hyperledger-cacti#2431 Co-authored-by: Peter Somogyvari <[email protected]> Signed-off-by: Peter Somogyvari <[email protected]> Signed-off-by: Tomasz Awramski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
ERROR: packages/cactus-plugin-ledger-connector-ubiquity/package.json dependencies.@hyperledger/cactus-core incorrectly has version 1.1.2. Expected 1.1.3
ERROR: packages/cactus-plugin-ledger-connector-ubiquity/package.json dependencies.@hyperledger/cactus-core-api incorrectly has version 1.1.2. Expected 1.1.3
ERROR: packages/cactus-plugin-ledger-connector-ubiquity/package.json devDependencies.@hyperledger/cactus-common incorrectly has version 1.1.2. Expected 1.1.3
ERROR: packages/cactus-plugin-ledger-connector-ubiquity/package.json devDependencies.@hyperledger/cactus-test-tooling incorrectly has version 1.1.2. Expected 1.1.3
Are these versions intentionally older for now or should I replace them?
https://github.com/hyperledger/cacti/blob/main/packages/cactus-plugin-ledger-connector-ubiquity/package.json
https://github.com/hyperledger/cacti/blob/3e6d908cb4cf732ef057a30df3e8267381f3f806/packages/cactus-plugin-ledger-connector-ubiquity/package.json#L58
The text was updated successfully, but these errors were encountered: