Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(examples): upgrade Angular to v14 #2377

Closed
petermetz opened this issue Apr 7, 2023 · 2 comments · Fixed by #2530
Closed

docs(examples): upgrade Angular to v14 #2377

petermetz opened this issue Apr 7, 2023 · 2 comments · Fixed by #2530
Assignees
@petermetz
Labels
dependencies Pull requests that update a dependency file enhancement New feature or request good-first-issue Good for newcomers good-first-issue-200-intermediate Hacktoberfest Hacktoberfest participants are welcome to take a stab at issues marked with this label. P2 Priority 2: High Security Related to existing or potential security vulnerabilities

Comments

@petermetz
Copy link
Contributor

Description

We need to do the upgrades step by step so this is just a milestone on the way to upgrading to v15.

Acceptance Criteria

  1. yarn build:dev passes
@petermetz petermetz added enhancement New feature or request good-first-issue Good for newcomers dependencies Pull requests that update a dependency file Security Related to existing or potential security vulnerabilities Hacktoberfest Hacktoberfest participants are welcome to take a stab at issues marked with this label. good-first-issue-200-intermediate P2 Priority 2: High labels Apr 7, 2023
@petermetz petermetz self-assigned this Apr 7, 2023
@petermetz petermetz mentioned this issue Apr 7, 2023
Closed
@PiyushSharma99
Copy link

Hi @petermetz, I am working on it

@petermetz
Copy link
Contributor Author

petermetz commented Jun 29, 2023 •
edited
Loading

@PiyushSharma99 I haven't seen a pull request about it yet so I'll take over because this is getting a bit urgent to finish.
If you happen to have the diff ready to go or close to it just let me know and I'm still happy to assign it!

P.S.: Apologies for the slow response!

petermetz added a commit to petermetz/cacti that referenced this issue Jun 29, 2023
@petermetz
docs(examples): upgrade Angular to v14
4fb6771 
1. Upgraded Angular from v13 to v14
2. Also bumped up the Ionic Framework dependencies
as needed because older versions that we were using
were not compatible [1] with Angular v14
3. Also did some of the Cactus -> Cacti renaming
in the front-end code namely the front-page of
both the supply chain and the carbon accounting
app examples.

[1] https://stackoverflow.com/a/72508644

Verbatim copy of the above link's comment:
==================================
The current version of Ionic v6.1.8 is not
compatible with Angular 14. Apparently,
it's been fixed in a dev release but it's not
stable yet. Have a look here
ionic-team/ionic-framework#25353
you can update @ionic/angular to
version 6.1.9-dev.11654275237.1b595be3
and re-run npm install.
Should work fine for now, if you wanna be on the edge.
==================================

Fixes hyperledger-cacti#2377

Signed-off-by: Peter Somogyvari <[email protected]>
@petermetz petermetz mentioned this issue Jun 29, 2023
Merged
petermetz added a commit that referenced this issue Jun 30, 2023
@petermetz
docs(examples): upgrade Angular to v14
fbb51cd 
1. Upgraded Angular from v13 to v14
2. Also bumped up the Ionic Framework dependencies
as needed because older versions that we were using
were not compatible [1] with Angular v14
3. Also did some of the Cactus -> Cacti renaming
in the front-end code namely the front-page of
both the supply chain and the carbon accounting
app examples.

[1] https://stackoverflow.com/a/72508644

Verbatim copy of the above link's comment:
==================================
The current version of Ionic v6.1.8 is not
compatible with Angular 14. Apparently,
it's been fixed in a dev release but it's not
stable yet. Have a look here
ionic-team/ionic-framework#25353
you can update @ionic/angular to
version 6.1.9-dev.11654275237.1b595be3
and re-run npm install.
Should work fine for now, if you wanna be on the edge.
==================================

Fixes #2377

Signed-off-by: Peter Somogyvari <[email protected]>
sandeepnRES pushed a commit to sandeepnRES/cacti that referenced this issue Dec 21, 2023
@petermetz @sandeepnRES
docs(examples): upgrade Angular to v14
3c84847 
1. Upgraded Angular from v13 to v14
2. Also bumped up the Ionic Framework dependencies
as needed because older versions that we were using
were not compatible [1] with Angular v14
3. Also did some of the Cactus -> Cacti renaming
in the front-end code namely the front-page of
both the supply chain and the carbon accounting
app examples.

[1] https://stackoverflow.com/a/72508644

Verbatim copy of the above link's comment:
==================================
The current version of Ionic v6.1.8 is not
compatible with Angular 14. Apparently,
it's been fixed in a dev release but it's not
stable yet. Have a look here
ionic-team/ionic-framework#25353
you can update @ionic/angular to
version 6.1.9-dev.11654275237.1b595be3
and re-run npm install.
Should work fine for now, if you wanna be on the edge.
==================================

Fixes hyperledger-cacti#2377

Signed-off-by: Peter Somogyvari <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@petermetz petermetz

Labels
dependencies Pull requests that update a dependency file enhancement New feature or request good-first-issue Good for newcomers good-first-issue-200-intermediate Hacktoberfest Hacktoberfest participants are welcome to take a stab at issues marked with this label. P2 Priority 2: High Security Related to existing or potential security vulnerabilities
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs(examples): upgrade Angular to v14 petermetz/cacti
2 participants
@petermetz @PiyushSharma99