Skip to content
This repository has been archived by the owner on May 13, 2022. It is now read-only.

Upgrade CI to docker 1.10.0 to fix remove image issue #576

Merged
merged 1 commit into from
Apr 13, 2017
Merged

Upgrade CI to docker 1.10.0 to fix remove image issue #576

merged 1 commit into from
Apr 13, 2017

Conversation

silasdavis
Copy link
Contributor

@silasdavis silasdavis commented Apr 13, 2017 •
edited
Loading

This PR:

  • Upgrades to Circle approved docker 1.10.0
  • Fixes issue where build image could not be removed
  • Reintroduces removal of build image so it is not pushed
  • Stops using repo username and instead hard codes hyperledger/burrow so CI will work against forks

@silasdavis silasdavis force-pushed the fix-ci branch 2 times, most recently from 5e69f8e to 0945236 Compare April 13, 2017 13:36
@silasdavis silasdavis changed the base branch from develop to master April 13, 2017 13:38
@silasdavis silasdavis changed the base branch from master to develop April 13, 2017 13:40
@silasdavis silasdavis changed the base branch from develop to release-0.16 April 13, 2017 13:42
@silasdavis silasdavis changed the base branch from release-0.16 to master April 13, 2017 13:42
@silasdavis silasdavis changed the base branch from master to develop April 13, 2017 13:42
@silasdavis silasdavis changed the title Test CI Upgrade CI to docker 1.10.0 to fix remove image issue Apr 13, 2017
@silasdavis
Copy link
Contributor Author

@benjaminbollen this is ready to reviewed/merged. I'm fairly confident it will restore our docker pushing to how it was before the move to hyperledger.

@compleatang compleatang merged commit c1ce6bb into hyperledger-archives:develop Apr 13, 2017
@silasdavis silasdavis deleted the fix-ci branch April 25, 2017 14:21
silasdavis pushed a commit to silasdavis/burrow that referenced this pull request Mar 9, 2019
Merge pull request hyperledger-archives#576 from silasdavis/fix-ci
1c89ed5 
Upgrade CI to docker 1.10.0 to fix remove image issue
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@benjaminbollen benjaminbollen Awaiting requested review from benjaminbollen

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@silasdavis @compleatang