This repository has been archived by the owner on May 13, 2022. It is now read-only.
Hacked away until buildable and runnable with Tendermint 0.8.0 #502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silasdavis
changed the title
silasdavis
force-pushed
the
feature-tendermint_0.8.0
branch
from
f3e2ad3
to
f459063
Compare
silasdavis
force-pushed
the
feature-tendermint_0.8.0
branch
from
f459063
to
c0da1cb
Compare
|
I will merge release-0.16 into eris-ltd:feature-tendermint_0.8.0; so that this PR gives a clearer picture of what has been done and where we are |
…eature-tendermint_0.8.0
silasdavis
force-pushed
the
feature-tendermint_0.8.0
branch
from
9efaad7
to
0816280
Compare
|
have rebased against eris-ltd/feature-tendermint_0.8.0 |
| @@ -55,7 +55,7 @@ func Multiplex(events ...EventEmitter) *multiplexedEvents { | |||
|
|
|||
| // The events struct has methods for working with events. | |||
| type events struct { | |||
| eventSwitch *go_events.EventSwitch | |||
| eventSwitch go_events.EventSwitch | |||
There was a problem hiding this comment.
why is this changed; a requirement or an improvement?
benjaminbollen
approved these changes
Feb 23, 2017
| @@ -1,4 +1,3 @@ | |||
| // +build integration | |||
|
|
|||
| // Space above here matters | |||
There was a problem hiding this comment.
best to remember to remove //space above here matters now ;)
| # listener address for accepting tendermint socket protocol connections | ||
| listener = "tcp://0.0.0.0:46658" | ||
|
|
||
| ################################################################################ | ||
| ## | ||
| ##yeah we had partial support for that with TMSP |
There was a problem hiding this comment.
we can remove this from the config
benjaminbollen
merged commit 5000562
into
hyperledger-archives:feature-tendermint_0.8.0
silasdavis
pushed a commit
to silasdavis/burrow
that referenced
this pull request
Mar 9, 2019
…endermint_0.8.0 Hacked away until buildable and runnable with Tendermint 0.8.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gets feature-tendermint_0.8.0 to a state where:
cs_wal_dirfeature-tendermint_0.8.0 is a WIP branch with failing tests. So this is potentially mergeable despite failing tests. We may be able to find a way to divide work at this point, or it may be easier for me to try and get a bit further.