Skip to content
This repository has been archived by the owner on May 13, 2022. It is now read-only.

updating develop with intermediate fixes from release-0.16 #479

Merged
merged 33 commits into from
Feb 11, 2017

Conversation

benjaminbollen
Copy link
Contributor

No description provided.

benjaminbollen and others added 26 commits November 4, 2016 03:16
…s no transaction can commence with delegatecall
…on_0.12

client/core: fixes 378 patch exception error from chain
b. issue366 only deploy from branch `release-0.12` for MASTER
 Begin stabilising v0.16.0 on release-0.16
Signed-off-by: RJ Catalano <[email protected]>
Signed-off-by: RJ Catalano <[email protected]>
issue-476: return One256 for EXTCODESIZE on native contracts
Copy link
Contributor Author

@benjaminbollen benjaminbollen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does NOT look good to me. (DNLGTM)

@@ -167,7 +168,15 @@ func (app *ErisMint) Commit() (res tmsp.Result) {
// flush events to listeners (XXX: note issue with blocking)
app.evc.Flush()

return tmsp.NewResultOK(app.state.Hash(), "Success")
// MARMOT:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not good.

@@ -156,7 +157,9 @@ func (vm *VM) DelegateCall(caller, callee *Account, code, input []byte, value in

exception := new(string)
// fire the post call event (including exception if applicable)
defer vm.fireCallEvent(exception, &output, caller, callee, input, value, gas)
// NOTE: [ben] hotfix for issue 371;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not good.

@@ -416,7 +416,10 @@ func MakeGenesisState(db dbm.DB, genDoc *genesis.GenesisDoc) *State {
}

if genDoc.GenesisTime.IsZero() {
genDoc.GenesisTime = time.Now()
// MARMOT: really?
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not good.

genDoc.GenesisTime = time.Now()
// MARMOT: really?
// set time to 11/18/2016 @ 4:09am (UTC)
genDoc.GenesisTime = time.Unix(1479442162, 0)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not good.

@benjaminbollen benjaminbollen added this to the 0.16.1 milestone Feb 10, 2017
@benjaminbollen
Copy link
Contributor Author

Merging release-0.16 (and with it master 0.12.1) into develop

@benjaminbollen benjaminbollen merged commit 1271a9b into develop Feb 11, 2017
silasdavis pushed a commit to silasdavis/burrow that referenced this pull request Mar 9, 2019
updating develop with intermediate fixes from release-0.16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants