Native support for ARM #137
Conversation
Changed MaxUint32 to MaxInt32 of erisdb/pipe/blockchain.go
Added support for alpine
|
LGTM, @benjaminbollen @silasdavis can we get a 👍 for the changes in the edb binary |
| @@ -1,3 +1,5 @@ | |||
| // +build !arm | |||
There was a problem hiding this comment.
what does this line do? OK, golang never ceases to amaze.
|
As an additional point, e-db is undergoing a restructuring, so we will have to port these changes to the new branches (ideally discuss-eris-gateway), but we can take this onboard as we make the transition |
|
The changes in blockchain.go refer to |
| if fd.Value == "min" { | ||
| val = 0 | ||
| } else if fd.Value == "max" { | ||
| val = math.MaxInt32 |
There was a problem hiding this comment.
var val int should be signed 32-bit integer on ARM v6 or v7, but the assignment val = math.MaxUint32 will overflow it. I tried to change the val type to uint32, but that would incur many other compilation errors. So the workaround for 32-bit ARM is to change the assignment to val = math.MaxInt32.
|
Please note that this will be overwritten as these files have moved in the restructuring of the consensus and pipe code. The preferred solution will be to use @zramsay thanks for linking this PR in a new issue |
Native support for ARM
closes https://github.com/eris-ltd/eris-cli/issues/718