This repository has been archived by the owner on Mar 27, 2024. It is now read-only.
refactor: Moved generic utility functions out of DIDExchange #993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fqutishat
approved these changes
Dec 17, 2019
troyronda
reviewed
Dec 17, 2019
troyronda
reviewed
Dec 17, 2019
Codecov Report
@@ Coverage Diff @@
## master #993 +/- ##
==========================================
- Coverage 90.88% 90.84% -0.04%
==========================================
Files 90 92 +2
Lines 5791 5791
==========================================
- Hits 5263 5261 -2
- Misses 286 287 +1
- Partials 242 243 +1
Continue to review full report at Codecov.
|
troyronda
reviewed
Dec 18, 2019
troyronda
approved these changes
Dec 18, 2019
troyronda
reviewed
Dec 18, 2019
pkg/doc/did/helpers.go
Outdated
| } | ||
|
|
||
| // LookupRecipientKeys gets the recipient keys from the did doc which match the given parameters. | ||
| func LookupRecipientKeys(didDoc *Doc, serviceType, keyType string) ([]string, error) { |
There was a problem hiding this comment.
(later) we may want to think about refactoring these static accessors and the existing instance fields.
llorllale
reviewed
Dec 18, 2019
Moopli
force-pushed
the
725-refactor
branch
2 times, most recently
from
7beaa53 to
7aed2de
Compare
added 2 commits
December 19, 2019 13:19
Signed-off-by: Filip Burlacu <[email protected]>
- DID doc parsing - Destination struct construction Signed-off-by: Filip Burlacu <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Functions moved out are for DID doc parsing and destination struct construction. These functions are needed for other protocols besides DIDExchange.
Part of #725