This repository has been archived by the owner on Mar 27, 2024. It is now read-only.
feat: Route Coordination - Structure for Grant and Keylist Update message types #956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #956 +/- ##
==========================================
- Coverage 91.12% 91.08% -0.05%
==========================================
Files 90 90
Lines 5712 5730 +18
==========================================
+ Hits 5205 5219 +14
- Misses 274 276 +2
- Partials 233 235 +2
Continue to review full report at Codecov.
|
sandrask
reviewed
Dec 11, 2019
…sage types - Implement [Route Grant](https://github.com/hyperledger/aries-rfcs/tree/master/features/0211-route-coordination#route-grant) handler - Implement [Route Keylist Update Response](https://github.com/hyperledger/aries-rfcs/tree/master/features/0211-route-coordination#keylist-update-response) handler Signed-off-by: Rolson Quadras <[email protected]>
rolsonquadras
force-pushed
the
issue-941
branch
from
67425bc to
2dff026
Compare
sandrask
approved these changes
Dec 11, 2019
|
@troyronda @fqutishat The patch coverage is less than 85%. I am not able to validate the lines where the code just logs and with no-return for err case. |
troyronda
approved these changes
Dec 11, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #941
Signed-off-by: Rolson Quadras [email protected]