feat: DIDComm Inbound Transport - Support for WebSocket #828
Conversation
Codecov Report
@@ Coverage Diff @@
## master #828 +/- ##
==========================================
- Coverage 91.25% 91.09% -0.16%
==========================================
Files 81 82 +1
Lines 4869 4928 +59
==========================================
+ Hits 4443 4489 +46
- Misses 229 236 +7
- Partials 197 203 +6
Continue to review full report at Codecov.
|
|
@troyronda @fqutishat current patch coverage is 78%. I'm finding it bit hard to cover the remaining lines (http/ws connection errors). |
pkg/didcomm/transport/ws/inbound.go
Outdated
| const processFailureErrMsg = "failed to process the message" | ||
|
|
||
| // provider contains dependencies for the WS Handler creation and is typically created by using aries.Context() | ||
| type provider interface { |
There was a problem hiding this comment.
is it needs to duplicate the same interface here?
you can simply implement the same interface found here https://github.com/hyperledger/aries-framework-go/blob/master/pkg/didcomm/transport/transport_interface.go#L28
unless you intend to create new functions
There was a problem hiding this comment.
Valid point, I missed the common interface. Removed.
rolsonquadras
force-pushed
the
issue-813
branch
from
0cf0b7e to
862a01f
Compare
Signed-off-by: Rolson Quadras <[email protected]>
rolsonquadras
force-pushed
the
issue-813
branch
from
862a01f to
bccdcfd
Compare
Closes #813
Signed-off-by: Rolson Quadras [email protected]