This repository has been archived by the owner on Mar 27, 2024. It is now read-only.
fix: Presentation Without Holder Binding should end with ~ #3468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix: Presentation Without Holder Binding should end with ~ Also, rename SDJWT to CombinedPresentation and JWTSerialized to SDJWT to follow spec terms. Closes hyperledger-archives#3467 Signed-off-by: Sandra Vrtikapa <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #3468 +/- ##
=======================================
Coverage 87.65% 87.66%
=======================================
Files 350 350
Lines 47483 47516 +33
=======================================
+ Hits 41623 41653 +30
- Misses 4348 4350 +2
- Partials 1512 1513 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
fqutishat
approved these changes
Jan 10, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: Presentation Without Holder Binding should end with ~
Also, rename SDJWT to CombinedPresentation and JWTSerialized to SDJWT to follow spec terms.
And add parsing and serializing of combined presentation parts with holder binding.
Holder Binding functionality will be added in separate PRs.
Closes #3467
Signed-off-by: Sandra Vrtikapa [email protected]