Skip to content
This repository has been archived by the owner on Mar 27, 2024. It is now read-only.

feat: SD-JWT Holder/Verifier - Process Disclosures #3460

Merged
merged 1 commit into from
Jan 5, 2023

Conversation

sandrask
Copy link
Contributor

@sandrask sandrask commented Jan 5, 2023

Added utility function to decode disclosures (used by both holder and verifier) Created disclose claims function for holder that re-creates SD-JWT with disclosures for selected claims only.

Created get verified payload function for verifier (removes _sd and _sd_alg from claims and inserts into payload disclosed claims).

Closes #3459

Signed-off-by: Sandra Vrtikapa [email protected]

@codecov
Copy link

codecov bot commented Jan 5, 2023

Codecov Report

Merging #3460 (5dac126) into main (ba18fdd) will increase coverage by 0.00%.
The diff coverage is 89.01%.

@@           Coverage Diff           @@
##             main    #3460   +/-   ##
=======================================
  Coverage   87.63%   87.64%           
=======================================
  Files         350      350           
  Lines       47354    47436   +82     
=======================================
+ Hits        41501    41573   +72     
- Misses       4343     4350    +7     
- Partials     1510     1513    +3     
Impacted Files Coverage Δ
pkg/doc/sdjwt/common/common.go 89.28% <85.00%> (-2.15%) ⬇️
pkg/doc/sdjwt/verifier/verifier.go 94.78% <85.00%> (-2.13%) ⬇️
pkg/doc/sdjwt/holder/holder.go 98.36% <96.66%> (-1.64%) ⬇️
pkg/doc/sdjwt/issuer/issuer.go 90.62% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@sandrask sandrask changed the title feat: SD-JWT Holder/Verifier - Process Disclosures wip: SD-JWT Holder/Verifier - Process Disclosures Jan 5, 2023

disclosureParts = 3
saltIndex = 0
nameIndex = 1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we always expect Claim Name binding?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, reference application is disclosing claims based on claim name.

@sandrask sandrask force-pushed the issue-3459 branch 2 times, most recently from 03097c2 to e20ad41 Compare January 5, 2023 18:06
Added utility function to decode disclosures (used by both holder and verifier)
Created disclose claims function for holder that re-creates SD-JWT with disclosures for selected claims only.

Created get verified payload function for verifier (removes _sd and _sd_alg from claims and inserts into payload disclosed claims).

Closes hyperledger-archives#3459

Signed-off-by: Sandra Vrtikapa <[email protected]>
@sandrask sandrask changed the title wip: SD-JWT Holder/Verifier - Process Disclosures feat: SD-JWT Holder/Verifier - Process Disclosures Jan 5, 2023
@sudeshrshetty sudeshrshetty merged commit aae6bb8 into hyperledger-archives:main Jan 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

SD-JWT Holder/Verifier - Process Disclosures
3 participants