Skip to content
This repository has been archived by the owner on Mar 27, 2024. It is now read-only.

Conversation

mishasizov-SK
Copy link
Contributor

Signed-off-by: Mykhailo Sizov [email protected]

Title:
Add did core support in resolving service endpoints function

Description:
Solves: #3428

Summary:
Added support of the next structure of service in DID:

"service": [
    {
      "id": "#linkeddomains",
      "type": "LinkedDomains",
      "serviceEndpoint": {
        "origins": [
          "https://did.rohitgulati.com/"
        ]
      }
    },
    {
      "id": "#hub",
      "type": "IdentityHub",
      "serviceEndpoint": {
        "instances": [
          "https://hub.did.msidentity.com/v1.0/a492cff2-d733-4057-95a5-a71fc3695bc8"
        ],
        "origins": []
      }
    }
  ]

Covered in unit test here: https://github.com/hyperledger/aries-framework-go/blob/main/pkg/doc/didconfig/interop_test.go#L37

@mishasizov-SK mishasizov-SK force-pushed the feat_add_did_core_support_in_service_endpoint_resolve_func branch from d249cb0 to d09f2bd Compare November 8, 2022 17:31
@codecov
Copy link

codecov bot commented Nov 8, 2022

Codecov Report

Merging #3429 (d09f2bd) into main (b2cd6a8) will decrease coverage by 0.00%.
The diff coverage is 37.50%.

@@            Coverage Diff             @@
##             main    #3429      +/-   ##
==========================================
- Coverage   87.56%   87.55%   -0.01%     
==========================================
  Files         343      343              
  Lines       46840    46846       +6     
==========================================
+ Hits        41014    41015       +1     
- Misses       4326     4330       +4     
- Partials     1500     1501       +1     
Impacted Files Coverage Δ
pkg/doc/did/doc.go 85.97% <37.50%> (-0.43%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@fqutishat fqutishat merged commit 39b5163 into hyperledger-archives:main Nov 9, 2022
@mishasizov-SK mishasizov-SK deleted the feat_add_did_core_support_in_service_endpoint_resolve_func branch June 15, 2023 09:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants