Skip to content
This repository has been archived by the owner on Mar 27, 2024. It is now read-only.

chore: Service priority should be an interface #3427

Merged
merged 1 commit into from
Nov 4, 2022

Conversation

sandrask
Copy link
Contributor

@sandrask sandrask commented Nov 3, 2022

Service.Priority should be an interface so it can be omitted if not set.

Closes #3426

Signed-off-by: Sandra Vrtikapa [email protected]

Service.Priority should be an interface so it can be omitted if not set.

Closes hyperledger-archives#3426

Signed-off-by: Sandra Vrtikapa <[email protected]>
@sandrask sandrask changed the title chore: Service priority should be an interface wip: Service priority should be an interface Nov 3, 2022
@codecov
Copy link

codecov bot commented Nov 4, 2022

Codecov Report

Merging #3427 (c4889a2) into main (368f53b) will decrease coverage by 0.01%.
The diff coverage is 90.90%.

@@            Coverage Diff             @@
##             main    #3427      +/-   ##
==========================================
- Coverage   87.57%   87.56%   -0.02%     
==========================================
  Files         343      343              
  Lines       46809    46840      +31     
==========================================
+ Hits        40994    41014      +20     
- Misses       4318     4326       +8     
- Partials     1497     1500       +3     
Impacted Files Coverage Δ
...to/primitive/aead/aes_cbc_hmac_aead_key_manager.go 90.74% <ø> (ø)
...tinkcrypto/primitive/bbs/bbs_signer_key_manager.go 83.46% <ø> (ø)
...nkcrypto/primitive/bbs/bbs_verifier_key_manager.go 100.00% <ø> (ø)
...composite/ecdh/ecdh_nistpkw_private_key_manager.go 90.07% <ø> (ø)
.../composite/ecdh/ecdh_nistpkw_public_key_manager.go 88.88% <ø> (ø)
...omposite/ecdh/ecdh_x25519kw_private_key_manager.go 82.94% <ø> (ø)
...composite/ecdh/ecdh_x25519kw_public_key_manager.go 88.88% <ø> (ø)
...imitive/composite/register_ecdh_aead_enc_helper.go 87.94% <ø> (ø)
...rimitive/secp256k1/secp256k1_signer_key_manager.go 82.90% <ø> (-2.57%) ⬇️
...mitive/secp256k1/secp256k1_verifier_key_manager.go 65.71% <ø> (ø)
... and 14 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@sandrask sandrask changed the title wip: Service priority should be an interface chore: Service priority should be an interface Nov 4, 2022
@sandrask sandrask changed the title chore: Service priority should be an interface wip: Service priority should be an interface Nov 4, 2022
@sandrask sandrask changed the title wip: Service priority should be an interface chore: Service priority should be an interface Nov 4, 2022
@fqutishat fqutishat merged commit b2cd6a8 into hyperledger-archives:main Nov 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Service priority should be an interface
2 participants