feat: Update Protocol Service API with Event handling functions (Register/Unregister) #335
Conversation
rolsonquadras
force-pushed
the
issue-332
branch
from
2479754 to
16f2363
Compare
Codecov Report
@@ Coverage Diff @@
## master #335 +/- ##
==========================================
+ Coverage 89.31% 89.42% +0.11%
==========================================
Files 45 44 -1
Lines 2479 2345 -134
==========================================
- Hits 2214 2097 -117
+ Misses 145 134 -11
+ Partials 120 114 -6
Continue to review full report at Codecov.
|
rolsonquadras
force-pushed
the
issue-332
branch
from
16f2363 to
02629fd
Compare
llorllale
requested review from
fqutishat,
sudeshrshetty,
troyronda,
sandrask,
talwinder50,
baha-ai and
bstasyszyn
and removed request for
sandrask,
bstasyszyn,
baha-ai and
sudeshrshetty
|
I think the new methods should be split off into their own interface. The dispatchers certainly have no need for them. |
rolsonquadras
force-pushed
the
issue-332
branch
from
02629fd to
e324a9c
Compare
@llorllale moved to different interface and embedded it. |
| @@ -67,3 +70,22 @@ type DIDCommCallback struct { | |||
|
|
|||
| // Callback type to pass service callbacks. | |||
| type Callback func(DIDCommCallback) | |||
|
|
|||
| // Event related apis. | |||
| type Event interface { | |||
There was a problem hiding this comment.
Sorry I wasn't clear before about the embedding: I think this new interface (whatever it will be named) should embed the existing dispatcher.Service interface, not the other way around. The dispatchers have no use for these new methods.
There was a problem hiding this comment.
@llorllale Created a new interface for DIDComm Services.
There was a problem hiding this comment.
I opened #344 to consider moving this interface to a different package in the future.
There was a problem hiding this comment.
@llorllale I had already raised one for that. May be we can close #344
…ster/Unregister) - Add Register/Unregister Action/Msg event APIs to Protocol Services Signed-off-by: Rolson Quadras <[email protected]>
rolsonquadras
force-pushed
the
issue-332
branch
from
e324a9c to
46a365e
Compare
Added Register/Unregister Action/Msg event APIs to Protocol Services. These were implemented in as part of Issue #276 and PR #327.
Closes #332
Signed-off-by: Rolson Quadras [email protected]