This repository has been archived by the owner on Mar 27, 2024. It is now read-only.
feat: add KMS key type for X25519 key #2486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2486 +/- ##
==========================================
- Coverage 89.29% 89.29% -0.01%
==========================================
Files 250 250
Lines 18851 18941 +90
==========================================
+ Hits 16833 16913 +80
- Misses 1187 1195 +8
- Partials 831 833 +2
Continue to review full report at Codecov.
|
baha-ai
requested review from
troyronda,
Moopli,
soluchok,
llorllale,
fqutishat,
rolsonquadras,
DRK3,
sandrask,
kdimak,
aholovko and
sudeshrshetty
DRK3
reviewed
Jan 25, 2021
DRK3
reviewed
Jan 25, 2021
DRK3
reviewed
Jan 25, 2021
DRK3
approved these changes
Jan 25, 2021
|
Left minor comments only |
baha-ai
changed the title
|
This PR requires additional updates in doc Jose encrypter/decrypter to account for X25519 support for packing (recipient key derivation using X25519 keys, not only NIST P curved keys). I will be pushing an update soon. |
baha-ai
changed the title
baha-ai
force-pushed
the
chachajwe
branch
2 times, most recently
from
f4516fe to
244d9b8
Compare
This is the last change about X25519 keys for ECDH KW. It updates the old ECDH key types into the new type names and add the X25519 key type as well. It includes JWE encryption/decryption updates to support XC20P content encryption along with recipients kw using both NIST P curved keys and X25519 keys. Also part of this change is the removal of remnant code from legacyKMS which was removed from the framework last year. closes hyperledger-archives#2447 closes hyperledger-archives#1684 closes hyperledger-archives#815 closes hyperledger-archives#475 closes hyperledger-archives#596 also part of hyperledger-archives#857 Signed-off-by: Baha Shaaban <[email protected]>
fqutishat
approved these changes
Jan 27, 2021
llorllale
approved these changes
Jan 27, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the last change about X25519 keys for ECDH KW.
It updates the old ECDH key types into the new type names
and add the X25519 key type as well.
It includes JWE encryption/decryption updates to support
XC20P content encryption along with recipients kw using both
NIST P curved keys and X25519 keys.
Also part of this change is the removal of remnant code
from legacyKMS which was removed from the framework last
year.
closes #2447
closes #1684
closes #815
closes #475
closes #596
also part of #857
Signed-off-by: Baha Shaaban [email protected]