Skip to content
This repository has been archived by the owner on Mar 27, 2024. It is now read-only.

feat: X25519 ECDH export pub key #2448

Merged
merged 1 commit into from
Jan 14, 2021

Conversation

baha-ai
Copy link
Contributor

@baha-ai baha-ai commented Jan 13, 2021

This change includes eporting the public key from ECDH Tink key templates
based on the key type and curve

closes #1806
closes #1637

Signed-off-by: Baha Shaaban [email protected]

@baha-ai baha-ai self-assigned this Jan 13, 2021
@codecov
Copy link

codecov bot commented Jan 13, 2021

Codecov Report

Merging #2448 (41d21f5) into master (7872928) will increase coverage by 0.03%.
The diff coverage is 90.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2448      +/-   ##
==========================================
+ Coverage   89.39%   89.42%   +0.03%     
==========================================
  Files         252      252              
  Lines       18069    18094      +25     
==========================================
+ Hits        16152    16180      +28     
+ Misses       1126     1123       -3     
  Partials      791      791              
Impacted Files Coverage Δ
pkg/crypto/tinkcrypto/crypto.go 91.45% <ø> (ø)
pkg/crypto/tinkcrypto/key_wrapper.go 94.87% <ø> (ø)
.../primitive/composite/keyio/composite_key_export.go 87.65% <90.00%> (+1.52%) ⬆️
...ite/ecdh/subtle/ecdh_aes_aead_composite_decrypt.go 100.00% <0.00%> (+14.28%) ⬆️
...ite/ecdh/subtle/ecdh_aes_aead_composite_encrypt.go 83.33% <0.00%> (+16.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7872928...41d21f5. Read the comment docs.

This change includes eporting the public key from ECDH Tink key templates
based on the key type and curve

closes hyperledger-archives#1806
closes hyperledger-archives#1637

Signed-off-by: Baha Shaaban <[email protected]>
@troyronda troyronda merged commit bca2267 into hyperledger-archives:master Jan 14, 2021
sudeshrshetty pushed a commit to sudeshrshetty/aries-framework-go that referenced this pull request Oct 18, 2021
sudeshrshetty pushed a commit to sudeshrshetty/aries-framework-go that referenced this pull request Jan 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Create New Chacha Key private/public key Managers for ECDH-1PU Tink key type Add chacha key templates
3 participants