-
Notifications
You must be signed in to change notification settings - Fork 160
feat: Present Proof - added correlation id #1962
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1962 +/- ##
==========================================
+ Coverage 90.96% 90.98% +0.02%
==========================================
Files 216 217 +1
Lines 16114 16089 -25
==========================================
- Hits 14658 14639 -19
+ Misses 854 852 -2
+ Partials 602 598 -4
Continue to review full report at Codecov.
|
Signed-off-by: Andrii Soluk <isoluchok@gmail.com>
@@ -29,6 +24,7 @@ import ( | |||
"github.com/hyperledger/aries-framework-go/pkg/doc/jose" | |||
"github.com/hyperledger/aries-framework-go/test/bdd/pkg/context" | |||
"github.com/hyperledger/aries-framework-go/test/bdd/pkg/sidetree" | |||
"github.com/hyperledger/aries-framework-go/test/bdd/pkg/util" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don’t usually like a generically named util package - sometimes unrelated functions start appearing in them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Totally agree about names :)
SPDX-License-Identifier: Apache-2.0 | ||
*/ | ||
|
||
package util |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there a more specific name possible for this package?
This PR adds a correlation id for the Present Proof protocol.
Closes #1945
Part of #1957
Signed-off-by: Andrii Soluk isoluchok@gmail.com