Skip to content
This repository has been archived by the owner on Mar 27, 2024. It is now read-only.

feat: Present Proof - added correlation id #1962

Merged
merged 1 commit into from
Jun 27, 2020
Merged

feat: Present Proof - added correlation id #1962

merged 1 commit into from
Jun 27, 2020

Conversation

soluchok
Copy link
Contributor

@soluchok soluchok commented Jun 26, 2020

This PR adds a correlation id for the Present Proof protocol.

Closes #1945
Part of #1957

Signed-off-by: Andrii Soluk isoluchok@gmail.com

@soluchok soluchok added blocked enhancement New feature or request labels Jun 26, 2020
@soluchok soluchok self-assigned this Jun 26, 2020
@soluchok soluchok added this to the 0.1.4 milestone Jun 26, 2020
@codecov
Copy link

codecov bot commented Jun 26, 2020

Codecov Report

Merging #1962 into master will increase coverage by 0.02%.
The diff coverage is 91.04%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1962      +/-   ##
==========================================
+ Coverage   90.96%   90.98%   +0.02%     
==========================================
  Files         216      217       +1     
  Lines       16114    16089      -25     
==========================================
- Hits        14658    14639      -19     
+ Misses        854      852       -2     
+ Partials      602      598       -4     
Impacted Files Coverage Δ
pkg/didcomm/protocol/presentproof/service.go 89.36% <33.33%> (-2.17%) ⬇️
pkg/controller/command/didexchange/command.go 94.97% <100.00%> (+3.58%) ⬆️
pkg/controller/command/presentproof/command.go 93.65% <100.00%> (+0.20%) ⬆️
pkg/didcomm/protocol/didexchange/service.go 90.37% <100.00%> (ø)
pkg/didcomm/protocol/presentproof/properties.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c513904...8509b7f. Read the comment docs.

@soluchok soluchok added wip and removed blocked labels Jun 26, 2020

Unverified

This user has not yet uploaded their public signing key.
Signed-off-by: Andrii Soluk <isoluchok@gmail.com>
@@ -29,6 +24,7 @@ import (
"github.com/hyperledger/aries-framework-go/pkg/doc/jose"
"github.com/hyperledger/aries-framework-go/test/bdd/pkg/context"
"github.com/hyperledger/aries-framework-go/test/bdd/pkg/sidetree"
"github.com/hyperledger/aries-framework-go/test/bdd/pkg/util"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don’t usually like a generically named util package - sometimes unrelated functions start appearing in them.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Totally agree about names :)

SPDX-License-Identifier: Apache-2.0
*/

package util
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there a more specific name possible for this package?

@llorllale llorllale merged commit cbafe55 into hyperledger-archives:master Jun 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Development

Successfully merging this pull request may close these issues.

presentproof controller: correlate outbound request-presentation & propose-presentation to their responses
3 participants