Skip to content
This repository has been archived by the owner on Mar 27, 2024. It is now read-only.

proposed solution to issue 1134 #1883

Closed
wants to merge 1 commit into from
Closed

proposed solution to issue 1134 #1883

wants to merge 1 commit into from

Conversation

m00sey
Copy link
Contributor

@m00sey m00sey commented Jun 2, 2020

Title:
Setting timeout on router client/service

Description:
Resolves #1134

Summary:

Decorator on router client for setting a timeout. The timeout is then propagated down to the route/mediator service.

I chose to modify the interface with an additional setTimeout method.

I preferred this to changing the Register() signature but options there could be:

explicitly with a timeout:
Register(connectionID string, timeout time.Duration) error

introduce some form of options for Register:
Register(connectionID string, opts ..*.Option) error

This seemed the most backward compatible with what is out there.

@m00sey m00sey closed this Jun 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Configure Timeout decorator in Route Messages
1 participant