-
Notifications
You must be signed in to change notification settings - Fork 160
feat: Add main crypto interfaces and proto buffs for a new ECDH-ES kw + AEAD crypto #1540
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1540 +/- ##
==========================================
+ Coverage 91.43% 91.45% +0.01%
==========================================
Files 164 164
Lines 11728 11728
==========================================
+ Hits 10724 10726 +2
+ Misses 569 567 -2
Partials 435 435
Continue to review full report at Codecov.
|
pkg/crypto/tinkcrypto/primitive/jwe/ecdhes/ecdh_aead_private_key_manager.go
Outdated
Show resolved
Hide resolved
pkg/crypto/tinkcrypto/primitive/jwe/ecdhes/register_ecdhes_aead_helper.go
Outdated
Show resolved
Hide resolved
pkg/crypto/tinkcrypto/primitive/jwe/ecdhes/ecdh_aead_public_key_manager.go
Outdated
Show resolved
Hide resolved
pkg/crypto/tinkcrypto/primitive/jwe/subtle/ecdhes/ecdhes_kw_aead_jwe_encrypt.go
Outdated
Show resolved
Hide resolved
pkg/crypto/tinkcrypto/primitive/jwe/subtle/ecdhes/ecdhes_kw_aead_jwe_encrypt.go
Outdated
Show resolved
Hide resolved
pkg/crypto/tinkcrypto/primitive/jwe/ecdhes/ecdh_aead_private_key_manager.go
Outdated
Show resolved
Hide resolved
pkg/crypto/tinkcrypto/primitive/jwe/ecdhes/ecdh_aead_public_key_manager.go
Outdated
Show resolved
Hide resolved
pkg/crypto/tinkcrypto/primitive/jwe/ecdhes/register_ecdhes_aead_helper.go
Outdated
Show resolved
Hide resolved
pkg/crypto/tinkcrypto/primitive/jwe/ecdhes/register_ecdhes_aead_helper.go
Outdated
Show resolved
Hide resolved
ecdhespb "github.com/hyperledger/aries-framework-go/pkg/crypto/tinkcrypto/primitive/proto/ecdhes_aead_go_proto" | ||
) | ||
|
||
// AES256GCMECDHESKeyTemplate is a KeyTemplate that generates an ECDH-ES P-256 key wrapping and AES256-GCM CEK with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we will need a todo for an additional chacha key wrapping template.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will add..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO added... chacha key wrapping is tbd
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
issue number?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
created #1637 and added it as a comment in the key templates
We will need to discuss how chacha key wrapping will be done if it must be supported. But for now we can add Chacha content encryption with ECDE-ES key wrapping using a key with P-256 curve.
789e5f1
to
0ac804c
Compare
9b1d521
to
4fae730
Compare
I reduced the scope of this PR and will push subsequent PRs for the rest of the Crypto primitives impelementations. |
@Baha-sk the PR description is still the same? |
70b5bb6
to
509d21a
Compare
…+AEAD Tink primtive type This is a first change for Anoncrypt crypto primitives mainly called Composite primitives. Following changes will build on top of this change, namely the crypto primitives, Tink templates and helpers to complete full ECDH-ES key wrapping + AEAD content encryption logic needed for building and parsing JWE messages. part of hyperledger-archives#1469 Signed-off-by: Baha Shaaban <[email protected]>
This is a first change for Anoncrypt crypto primitives mainly called Composite primitives.
Following changes will build on top of this change, namely the crypto primitives, Tink templates
and helpers to complete full ECDH-ES key wrapping + AEAD content encryption logic needed
for building and parsing JWE messages.
part of #1469
Signed-off-by: Baha Shaaban [email protected]