Skip to content
This repository has been archived by the owner on Mar 27, 2024. It is now read-only.

ci: include test files in linter #84

Closed
troyronda opened this issue Aug 9, 2019 · 5 comments · Fixed by #85
Closed

ci: include test files in linter #84

troyronda opened this issue Aug 9, 2019 · 5 comments · Fixed by #85
Assignees
@troyronda
Labels
bug Something isn't working chore

Comments

@troyronda
Copy link
Contributor

This should fail:
https://github.com/hyperledger/aries-framework-go/pull/66/files#diff-7de7681f01cd73c279bb10b7466c2953R127
@troyronda troyronda added the bug Something isn't working label Aug 9, 2019
@llorllale
Copy link
Contributor

I could not reproduce this by moving around closing brackets in the master branch

@troyronda
Copy link
Contributor Author

@llorllale Are you saying this is happening only on CircleCI not locally?

@llorllale
Copy link
Contributor

@troyronda no. I just pulled @talwinder50's branch and make lint runs with no issues

@rolsonquadras
Copy link
Contributor

@troyronda I think it didn't fail as test files are ignored from linter check - https://github.com/hyperledger/aries-framework-go/blob/master/.golangci.yml#L15

@troyronda
Copy link
Contributor Author

We shouldn’t exclude test files. I’ll update description.

@troyronda troyronda changed the title ci: linter seems to be missing formatting issues ci: include test files in linter Aug 9, 2019
@troyronda troyronda self-assigned this Aug 12, 2019
@troyronda troyronda mentioned this issue Aug 12, 2019
Merged
talwinder50 pushed a commit to talwinder50/aries-framework-go that referenced this issue Aug 31, 2019
@troyronda @talwinder50
ci: include test files in linter
7e67007 
Update golangci to lint test files.
Fix lint warnings in test files.

Closes: hyperledger-archives#84

Signed-off-by: Troy Ronda <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@troyronda troyronda

Labels
bug Something isn't working chore
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ci: include test files in linter
3 participants
@troyronda @llorllale @rolsonquadras