Skip to content
This repository has been archived by the owner on Mar 27, 2024. It is now read-only.

feat: logging interface and default implementation #21

Closed
sudeshrshetty opened this issue Jul 19, 2019 · 3 comments · Fixed by #57
Closed

feat: logging interface and default implementation #21

sudeshrshetty opened this issue Jul 19, 2019 · 3 comments · Fixed by #57
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@sudeshrshetty
Copy link
Contributor

Define generic logging interface for aries framework and provide default implementation.

@llorllale
Copy link
Contributor

@sudeshrshetty what do you have in mind?

@troyronda troyronda added the enhancement New feature or request label Jul 19, 2019
@sudeshrshetty
Copy link
Contributor Author

sudeshrshetty commented Jul 24, 2019

//Logger - Standard logger interface
type Logger interface {

//Fatalf is critical fatal logging, should possibly followed by system shutdown
Fatalf(msg string, args ...interface{})

//Panicf is critical logging, should possibly followed by panic
Panicf(msg string, args ...interface{})

//Debugf is for logging verbose messages
Debugf(msg string, args ...interface{})

//Infof for logging general logging messages
Infof(msg string, args ...interface{})

//Warnf is for logging messages about possible issues
Warnf(msg string, args ...interface{})

//Errorf is for logging errors
Errorf(msg string, args ...interface{})

}

Custom implementation can be provided by calling logging.Initialize(customProvider) before using logger (means, before logging any lines).

Logging levels will be maintained by aries framework and it will be module based.
Like, each modules can have their own logging levels enabled.
Default logging level is INFO

sudeshrshetty added a commit to sudeshrshetty/aries-framework-go that referenced this issue Jul 24, 2019
- provided logging interface
- log levels supported - CRITICAL, ERROR, WARNING, INFO, DEBUG, where
INFO is default logging level
-logging levels will be managed by framework which is module based,
where each modules can maintain their own logging levels
- refers issue hyperledger-archives#21 where more details can be found

Signed-off-by: sudesh.shetty <[email protected]>
sudeshrshetty added a commit to sudeshrshetty/aries-framework-go that referenced this issue Jul 24, 2019
- provided logging interface
- log levels supported - CRITICAL, ERROR, WARNING, INFO, DEBUG, where
INFO is default logging level
-logging levels will be managed by framework which is module based,
where each modules can maintain their own logging levels
- refers issue hyperledger-archives#21 where more details can be found

Signed-off-by: sudesh.shetty <[email protected]>
sudeshrshetty added a commit to sudeshrshetty/aries-framework-go that referenced this issue Jul 24, 2019
-provided logging interface
-log levels supported - CRITICAL, ERROR, WARNING, INFO, DEBUG, where
INFO is default logging level
-logging provider implementation can be used to provide custom logging
provider
- addresses hyperledger-archives#21

Signed-off-by: sudesh.shetty <[email protected]>
sudeshrshetty added a commit to sudeshrshetty/aries-framework-go that referenced this issue Jul 24, 2019
-provided logging interface
-log levels supported - CRITICAL, ERROR, WARNING, INFO, DEBUG, where
INFO is default logging level
-logging provider implementation can be used to provide custom logging
provider
-resolves hyperledger-archives#21

Signed-off-by: sudesh.shetty <[email protected]>
sudeshrshetty added a commit to sudeshrshetty/aries-framework-go that referenced this issue Jul 24, 2019
-provided logging interface
-log levels supported - CRITICAL, ERROR, WARNING, INFO, DEBUG, where
INFO is default logging level
-logging provider implementation can be used to provide custom logging
provider
-resolves hyperledger-archives#21

Signed-off-by: sudesh.shetty <[email protected]>
sudeshrshetty added a commit to sudeshrshetty/aries-framework-go that referenced this issue Jul 25, 2019
-provided logging interface
-log levels supported - CRITICAL, ERROR, WARNING, INFO, DEBUG, where
INFO is default logging level
-logging provider implementation can be used to provide custom logging
provider
-Story hyperledger-archives#21

Signed-off-by: sudesh.shetty <[email protected]>
sudeshrshetty added a commit to sudeshrshetty/aries-framework-go that referenced this issue Jul 29, 2019
- added module based log levels implementation where default log level is INFO
- added module and log level based caller info feature which shows caller function
names in log lines for given module and level configured.
- logger opts implementation is added which can be used by logger implementation
- Story: hyperledger-archives#21

Signed-off-by: sudesh.shetty <[email protected]>
sudeshrshetty added a commit to sudeshrshetty/aries-framework-go that referenced this issue Jul 29, 2019
- added module based log levels implementation where default log level is INFO
- added module and log level based caller info feature which shows caller function
names in log lines for given module and level configured.
- logger opts implementation is added which can be used by logger implementation
- Story: hyperledger-archives#21

Signed-off-by: sudesh.shetty <[email protected]>
sudeshrshetty added a commit to sudeshrshetty/aries-framework-go that referenced this issue Jul 29, 2019
- added module based log levels implementation where default log level is INFO
- added module and log level based caller info feature which shows caller function
names in log lines for given module and level configured.
- logger opts implementation is added which can be used by logger implementation
- Story: hyperledger-archives#21

Signed-off-by: sudesh.shetty <[email protected]>
sudeshrshetty added a commit to sudeshrshetty/aries-framework-go that referenced this issue Jul 29, 2019
- defLog : default implementation of moduled logger built on top
of go 'log' package
- modLog: moduled level based logger implementation wrapping custom logger implementation
- Story: hyperledger-archives#21

Signed-off-by: sudesh.shetty <[email protected]>
sudeshrshetty added a commit to sudeshrshetty/aries-framework-go that referenced this issue Jul 29, 2019
- defLog : default implementation of moduled logger built on top
of go 'log' package.
- modLog: moduled level based logger implementation wrapping custom logger implementation.
- Story: hyperledger-archives#21

Signed-off-by: sudesh.shetty <[email protected]>
sudeshrshetty added a commit to sudeshrshetty/aries-framework-go that referenced this issue Jul 29, 2019
- defLog : default implementation of moduled logger built on top
of go 'log' package.
- modLog: moduled level based logger implementation wrapping custom logger implementation.
- Story: hyperledger-archives#21

Signed-off-by: sudesh.shetty <[email protected]>
sudeshrshetty added a commit to sudeshrshetty/aries-framework-go that referenced this issue Jul 30, 2019
- defLog : default implementation of moduled logger built on top
of go 'log' package.
- modLog: moduled level based logger implementation wrapping custom logger implementation.
- Story: hyperledger-archives#21

Signed-off-by: sudesh.shetty <[email protected]>
sudeshrshetty added a commit to sudeshrshetty/aries-framework-go that referenced this issue Jul 30, 2019
- defLog : default implementation of moduled logger built on top
of go 'log' package.
- modLog: moduled level based logger implementation wrapping custom logger implementation.
- Story: hyperledger-archives#21

Signed-off-by: sudesh.shetty <[email protected]>
sudeshrshetty added a commit to sudeshrshetty/aries-framework-go that referenced this issue Jul 30, 2019
- defLog : default implementation of moduled logger built on top
of go 'log' package.
- modLog: moduled level based logger implementation wrapping custom logger implementation.
- Story: hyperledger-archives#21

Signed-off-by: sudesh.shetty <[email protected]>
sudeshrshetty added a commit to sudeshrshetty/aries-framework-go that referenced this issue Jul 30, 2019
- defLog : default implementation of moduled logger built on top
of go 'log' package.
- modLog: moduled level based logger implementation wrapping custom logger implementation.
- Story: hyperledger-archives#21

Signed-off-by: sudesh.shetty <[email protected]>
sudeshrshetty added a commit to sudeshrshetty/aries-framework-go that referenced this issue Jul 30, 2019
- defLog : default implementation of moduled logger built on top
of go 'log' package.
- modLog: moduled level based logger implementation wrapping custom logger implementation.
- Story: hyperledger-archives#21

Signed-off-by: sudesh.shetty <[email protected]>
sudeshrshetty added a commit to sudeshrshetty/aries-framework-go that referenced this issue Jul 30, 2019
- defLog : default implementation of moduled logger built on top
of go 'log' package.
- modLog: moduled level based logger implementation wrapping custom logger implementation.
- Story: hyperledger-archives#21

Signed-off-by: sudesh.shetty <[email protected]>
sudeshrshetty added a commit to sudeshrshetty/aries-framework-go that referenced this issue Jul 30, 2019
- defLog : default implementation of moduled logger built on top
of go 'log' package.
- modLog: moduled level based logger implementation wrapping custom logger implementation.
- Story: hyperledger-archives#21

Signed-off-by: sudesh.shetty <[email protected]>
sudeshrshetty added a commit to sudeshrshetty/aries-framework-go that referenced this issue Jul 31, 2019
- added implementation for logger provider injection using
log.Initialize() function, which should be called before logging any
line to use custom loger implementation
- implemented log.NewLogger() which returns new instance of logger based
on logger provider initialized
- exposed APIs for log level and caller info management
- closes:hyperledger-archives#21

Signed-off-by: sudesh.shetty <[email protected]>
sudeshrshetty added a commit to sudeshrshetty/aries-framework-go that referenced this issue Jul 31, 2019
- added implementation for logger provider injection using
log.Initialize() function, which should be called before logging any
line to use custom loger implementation
- implemented log.NewLogger() which returns new instance of logger based
on logger provider initialized
- exposed APIs for log level and caller info management
- closes:hyperledger-archives#21

Signed-off-by: sudesh.shetty <[email protected]>
sudeshrshetty added a commit to sudeshrshetty/aries-framework-go that referenced this issue Jul 31, 2019
- added implementation for logger provider injection using
log.Initialize() function, which should be called before logging any
line to use custom loger implementation
- implemented log.NewLogger() which returns new instance of logger based
on logger provider initialized
- exposed APIs for log level and caller info management
- closes:hyperledger-archives#21

Signed-off-by: sudesh.shetty <[email protected]>
sudeshrshetty added a commit to sudeshrshetty/aries-framework-go that referenced this issue Aug 1, 2019
- added implementation for logger provider injection using
log.Initialize() function, which should be called before logging any
line to use custom loger implementation
- implemented log.NewLogger() which returns new instance of logger based
on logger provider initialized
- exposed APIs for log level and caller info management
- closes:hyperledger-archives#21

Signed-off-by: sudesh.shetty <[email protected]>
sudeshrshetty added a commit to sudeshrshetty/aries-framework-go that referenced this issue Aug 1, 2019
- added implementation for logger provider injection using
log.Initialize() function, which should be called before logging any
line to use custom loger implementation
- implemented log.NewLogger() which returns new instance of logger based
on logger provider initialized
- exposed APIs for log level and caller info management
- closes:hyperledger-archives#21

Signed-off-by: sudesh.shetty <[email protected]>
@llorllale llorllale added this to the 0.1.0 milestone Aug 7, 2019
talwinder50 pushed a commit to talwinder50/aries-framework-go that referenced this issue Aug 31, 2019
-provided logging interface
-log levels supported - CRITICAL, ERROR, WARNING, INFO, DEBUG, where
INFO is default logging level
-logging provider implementation can be used to provide custom logging
provider
-Story hyperledger-archives#21

Signed-off-by: sudesh.shetty <[email protected]>
talwinder50 pushed a commit to talwinder50/aries-framework-go that referenced this issue Aug 31, 2019
- added module based log levels implementation where default log level is INFO
- added module and log level based caller info feature which shows caller function
names in log lines for given module and level configured.
- logger opts implementation is added which can be used by logger implementation
- Story: hyperledger-archives#21

Signed-off-by: sudesh.shetty <[email protected]>
talwinder50 pushed a commit to talwinder50/aries-framework-go that referenced this issue Aug 31, 2019
- defLog : default implementation of moduled logger built on top
of go 'log' package.
- modLog: moduled level based logger implementation wrapping custom logger implementation.
- Story: hyperledger-archives#21

Signed-off-by: sudesh.shetty <[email protected]>
talwinder50 pushed a commit to talwinder50/aries-framework-go that referenced this issue Aug 31, 2019
- added implementation for logger provider injection using
log.Initialize() function, which should be called before logging any
line to use custom loger implementation
- implemented log.NewLogger() which returns new instance of logger based
on logger provider initialized
- exposed APIs for log level and caller info management
- closes:hyperledger-archives#21

Signed-off-by: sudesh.shetty <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Development

Successfully merging a pull request may close this issue.

3 participants