Skip to content
This repository has been archived by the owner on Mar 27, 2024. It is now read-only.

rename Ecdhes key type and proto structs to include A256GCM and A256KW #1804

Closed
baha-ai opened this issue May 8, 2020 · 0 comments · Fixed by #1829
Closed

rename Ecdhes key type and proto structs to include A256GCM and A256KW #1804

baha-ai opened this issue May 8, 2020 · 0 comments · Fixed by #1829
Assignees
@baha-ai
Labels
enhancement New feature or request refactor
Milestone
0.1.4

Comments

@baha-ai
Copy link
Contributor

baha-ai commented May 8, 2020 •
edited
Loading

The current JWE key templates were based off of Tink Hybrid which does not specify the key types and curves used.

In order to distinguish the default A256GCM content encryption and A256KW key wrapping from Chacha keys, they need to be renamed along with their key manager and protos.

This will help introduce key tempates and managers for Chacha with X25519/A256 KW
@baha-ai baha-ai self-assigned this May 8, 2020
@baha-ai baha-ai added enhancement New feature or request refactor labels May 8, 2020
@baha-ai baha-ai added this to the 0.1.4 milestone May 8, 2020
@baha-ai baha-ai mentioned this issue May 8, 2020
Closed
6 tasks
baha-ai pushed a commit to baha-ai/aries-framework-go that referenced this issue May 13, 2020
refactor: rename ECDHES Tink Key to distinguish NIST vs Chacha crypto
74eb010 
This change renames current ECDHES Tink key to prepare for adding support
for (X)Chacha/X25519 type as ECDHES Tink key type.

The following was changed:
* Files names renamed to include `AES` keyword
* new `KeyType` added in the proto, PublicKey and current logic to seperate EC keys from Chacha keys

Closes hyperledger-archives#1804
Closes hyperledger-archives#1805

Signed-off-by: Baha Shaaban <[email protected]>
@baha-ai baha-ai mentioned this issue May 13, 2020
Merged
baha-ai pushed a commit to baha-ai/aries-framework-go that referenced this issue May 13, 2020
refactor: rename ECDHES Tink Key to distinguish NIST vs Chacha crypto
fd32913 
This change renames current ECDHES Tink key to prepare for adding support
for (X)Chacha/X25519 type as ECDHES Tink key type.

The following was changed:
* Files names renamed to include `AES` keyword
* new `KeyType` added in the proto, PublicKey and current logic to seperate EC keys from Chacha keys

Closes hyperledger-archives#1804
Closes hyperledger-archives#1805

Signed-off-by: Baha Shaaban <[email protected]>
baha-ai pushed a commit to baha-ai/aries-framework-go that referenced this issue May 14, 2020
refactor: rename ECDHES Tink Key to distinguish AES vs ChaCha crypto
6f4ff4b 
This change renames current ECDHES Tink key to prepare for adding support
for (X)Chacha/X25519 type as ECDHES Tink key type.

The following was changed:
* Files names renamed to include `AES` keyword
* new `KeyType` added in the proto, PublicKey and current logic to seperate AES keys from ChaCha keys

Closes hyperledger-archives#1804
Closes hyperledger-archives#1805

Signed-off-by: Baha Shaaban <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@baha-ai baha-ai

Labels
enhancement New feature or request refactor
Milestone
0.1.4
Development

Successfully merging a pull request may close this issue.

refactor: rename ECDHES Tink Key to distinguish AES vs ChaCha baha-ai/aries-framework-go
1 participant
@baha-ai