Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to latest Wagmi + Rainbowkit #80

Closed
jmrossy opened this issue Nov 12, 2023 · 2 comments · Fixed by #89
Closed

Update to latest Wagmi + Rainbowkit #80

jmrossy opened this issue Nov 12, 2023 · 2 comments · Fixed by #89
Assignees
Labels

Comments

@jmrossy
Copy link
Collaborator

jmrossy commented Nov 12, 2023

We're stuck on older versions for Ethers V5 support.
We'd need to adapt the SDK txs for Viem, as that's what newer Wagmi versions require.

Improves Warp UI wallet connection experience

@avious00
Copy link
Contributor

captured in backlog

@jmrossy jmrossy moved this from Backlog to Sprint in Hyperlane Tasks Nov 20, 2023
@jmrossy jmrossy self-assigned this Nov 20, 2023
@jmrossy
Copy link
Collaborator Author

jmrossy commented Nov 20, 2023

@tkporter mentioned as part of the hackathon feedback that our older wagmi version and the ethers-only SDK txs were a problem for some participants. I'm not surprised to hear that, it will probably happen more often as viem's popularity grows.

We can update SDK to be lib agnostic, or at least provide the utilities someone would need to adapter ethers<->viem. Viem itself has a bit of documentation about this but it doesn't cover everything we would need:
https://wagmi.sh/core/ethers-adapters
wevm/wagmi#2340

@avious00 avious00 moved this from Sprint to Backlog in Hyperlane Tasks Nov 21, 2023
@avious00 avious00 moved this from Backlog to Sprint in Hyperlane Tasks Dec 11, 2023
@jmrossy jmrossy moved this from Sprint to In Progress in Hyperlane Tasks Dec 12, 2023
jmrossy added a commit to hyperlane-xyz/hyperlane-monorepo that referenced this issue Dec 15, 2023
### Description

- Upgrade Viem and wagmi chains versions
- Add optional RestUrl field to ChainMetadata
- Set rest url for Neutron
- Add simple deepCopy function

Prerequisite for hyperlane-xyz/hyperlane-warp-ui-template#80

### Backward compatibility

Yes

### Testing

Tested in Warp UI
@github-project-automation github-project-automation bot moved this from In Progress to Done in Hyperlane Tasks Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants