Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: agent config artifact includes only chains user deployed to #3223

Merged
merged 1 commit into from
Feb 5, 2024
Merged

fix: agent config artifact includes only chains user deployed to #3223

merged 1 commit into from
Feb 5, 2024

Conversation

paulbalaji
Copy link
Contributor

@paulbalaji paulbalaji commented Feb 5, 2024 •
edited
Loading

resolves #3189

  • only build agent config for chains deployed to
  • drive-by retrieve HyperlaneCore outside of the loop

TODO:

  • check if it resolves bug with kurtosis deploy url

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Feb 5, 2024

⚠️ No Changeset found

Latest commit: 6d32b2f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

jmrossy
jmrossy approved these changes Feb 5, 2024
View reviewed changes
typescript/cli/src/deploy/core.ts Show resolved Hide resolved
@paulbalaji paulbalaji enabled auto-merge (squash) February 5, 2024 17:50
@paulbalaji paulbalaji merged commit 8bfa8c1 into main Feb 5, 2024
8 of 15 checks passed
@paulbalaji paulbalaji deleted the feat/pb-3189 branch February 5, 2024 17:50
ltyu pushed a commit to ltyu/hyperlane-monorepo that referenced this pull request Mar 13, 2024
@paulbalaji @ltyu
fix: agent config artifact includes only chains user deployed to (hyp…
35e09d8 
…erlane-xyz#3223)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmrossy jmrossy jmrossy approved these changes

@yorhodes yorhodes Awaiting requested review from yorhodes yorhodes is a code owner

@aroralanuk aroralanuk Awaiting requested review from aroralanuk

Assignees
No one assigned
Labels
None yet
Projects
Hyperlane Tasks
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Prune agent artifacts to only contain relevant chains
2 participants
@paulbalaji @jmrossy