Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat:removing igp from preset hook config #3215

Merged
merged 2 commits into from
Feb 2, 2024

Conversation

aroralanuk
Copy link
Contributor

Description

  • To simplify the PI deployment, I've removed the igp from preset hook config which PI deployers use if they don't provide a hook config via the CLI.
  • This means we don't need to deploy IGP or storage gas oracles and the PI deployer can spin up relayer with gas enforcement policy set to false.

Drive-by changes

None

Related issues

None

Backward compatibility

Yes

Testing

Manual

Copy link

changeset-bot bot commented Feb 2, 2024

🦋 Changeset detected

Latest commit: 91e243b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
Name Type
@hyperlane-xyz/cli Patch
@hyperlane-xyz/core Patch
@hyperlane-xyz/helloworld Patch
@hyperlane-xyz/infra Patch
@hyperlane-xyz/sdk Patch
@hyperlane-xyz/utils Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@aroralanuk aroralanuk enabled auto-merge (squash) February 2, 2024 19:52
Copy link

codecov bot commented Feb 2, 2024

Codecov Report

Merging #3215 (91e243b) into main (8907a71) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3215   +/-   ##
=======================================
  Coverage   67.65%   67.65%           
=======================================
  Files          99       99           
  Lines        1014     1014           
  Branches      106      106           
=======================================
  Hits          686      686           
  Misses        284      284           
  Partials       44       44           
Components Coverage Δ
core 50.00% <ø> (ø)
hooks 68.79% <ø> (ø)
isms 65.94% <ø> (ø)
token 58.41% <ø> (ø)
middlewares 81.46% <ø> (ø)

@aroralanuk aroralanuk merged commit 99fe93a into main Feb 2, 2024
21 of 22 checks passed
@aroralanuk aroralanuk deleted the kunal/preset-default-hook-as-merkle branch February 2, 2024 20:18
ltyu pushed a commit to ltyu/hyperlane-monorepo that referenced this pull request Mar 13, 2024
### Description

- To simplify the PI deployment, I've removed the igp from preset hook
config which PI deployers use if they don't provide a hook config via
the CLI.
- This means we don't need to deploy IGP or storage gas oracles and the
PI deployer can spin up relayer with gas enforcement policy set to
false.

### Drive-by changes

None

### Related issues

None

### Backward compatibility

Yes
### Testing

Manual
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants