Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix address util nullish fallback handling #3181

Merged
merged 3 commits into from
Jan 24, 2024
Merged

Conversation

jmrossy
Copy link
Contributor

@jmrossy jmrossy commented Jan 24, 2024

Description

Small fix for address utils

Related issues

https://github.com/hyperlane-xyz/issues/issues/899

Backward compatibility

Yes

Testing

In warp UI

Copy link

changeset-bot bot commented Jan 24, 2024

🦋 Changeset detected

Latest commit: 8805aee

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
Name Type
@hyperlane-xyz/utils Patch
@hyperlane-xyz/core Patch
@hyperlane-xyz/cli Patch
@hyperlane-xyz/infra Patch
@hyperlane-xyz/sdk Patch
@hyperlane-xyz/helloworld Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

typescript/utils/src/typeof.ts Show resolved Hide resolved
Copy link

codecov bot commented Jan 24, 2024

Codecov Report

Merging #3181 (8805aee) into main (6845f9f) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3181   +/-   ##
=======================================
  Coverage   67.18%   67.18%           
=======================================
  Files         101      101           
  Lines        1021     1021           
  Branches      106      106           
=======================================
  Hits          686      686           
  Misses        291      291           
  Partials       44       44           
Components Coverage Δ
core 50.00% <ø> (ø)
hooks 68.79% <ø> (ø)
isms 65.94% <ø> (ø)
token 54.62% <ø> (ø)
middlewares 81.46% <ø> (ø)

@jmrossy jmrossy enabled auto-merge (squash) January 24, 2024 21:36
@jmrossy jmrossy merged commit df24eec into main Jan 24, 2024
21 of 22 checks passed
@jmrossy jmrossy deleted the rossy/utils-nullish-fix branch January 24, 2024 21:49
ltyu pushed a commit to ltyu/hyperlane-monorepo that referenced this pull request Mar 13, 2024
### Description

Small fix for address utils

### Related issues

hyperlane-xyz/issues#899

### Backward compatibility

Yes

### Testing

In warp UI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants