feat:update deployments to use FallbackRoutingHook
#3179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aroralanuk
requested review from
tkporter,
nambrot,
yorhodes and
jmrossy
as code owners
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3179 +/- ##
=======================================
Coverage 67.65% 67.65%
=======================================
Files 99 99
Lines 1014 1014
Branches 106 106
=======================================
Hits 686 686
Misses 284 284
Partials 44 44
|
aroralanuk
changed the title
FallbackRoutingHookFallbackRoutingHook
yorhodes
approved these changes
Jan 24, 2024
jmrossy
approved these changes
Jan 26, 2024
ltyu
pushed a commit
to ltyu/hyperlane-monorepo
that referenced
this pull request
Mar 13, 2024
) ### Description - mainnet3, testnet4 should be using fallback routing hooks because it's more "porous" for first-time deployers of hyperlane to have merkleTreeHook out of the box ### Drive-by changes - added overrides to configureHook in basedeployer and setHook in hookdeployer - added fetching local rpc first logic in infra/chains and then secrets rpc if needed. This would mean the forking and live setup will be closer as the rpc urls will be the same between the two. ### Related issues None ### Backward compatibility Yes ### Testing Fork
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Drive-by changes
Related issues
None
Backward compatibility
Yes
Testing
Fork