Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: add rustfmt #3133

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

NOOMA-42
Copy link
Contributor

@NOOMA-42 NOOMA-42 commented Jan 7, 2024

Description

add rustfmt

Drive-by changes

  • add rustfmt
  • modify precommit husky file

Related issues

Backward compatibility

Yes

Testing

Manual Tests:

  1. run
    cargo +nightly fmt --all --check --manifest-path rust/Cargo.toml
    in root folder
  2. commit something to test husky

TODO: I only run fmt in check mode and haven't applied the change, should I apply?

Copy link

changeset-bot bot commented Jan 7, 2024

⚠️ No Changeset found

Latest commit: 030b5e5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

@daniel-savu daniel-savu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening! We're not using nightly rust anywhere in the codebase so I'd rather wait until this feature becomes stabilized. There's no clear timeline for stabilizing it unfortunately, but happy to merge your PR once this is stabilized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Review
Development

Successfully merging this pull request may close these issues.

Add a rustfmt file
2 participants