Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TxSearch with block-by-block indexing #3234

Closed
1 task
avious00 opened this issue Feb 7, 2024 · 0 comments · Fixed by #3245
Closed
1 task

Fix TxSearch with block-by-block indexing #3234

avious00 opened this issue Feb 7, 2024 · 0 comments · Fixed by #3245
Assignees
Labels

Comments

@avious00
Copy link
Contributor

avious00 commented Feb 7, 2024

Fix Neutron Validator Indexing for TxSearch with block-by-block indexing

Problem

We need to design a sustainable method for Cosmos indexing, TxSearch is unreliable.

  • it can give back junk responses depending on the timeout of the RPC server
  • we require an archive node to index older messages
  • sometimes TxSearch isn’t public because it’s such an expensive RPC
  • Results in neutron validators getting stuck or not being able to index older messages, so we have gaps in checkpoints

Solution

Additional context

Related issues

Tasks

Preview Give feedback
  1. daniel-savu
@avious00 avious00 added the agent label Feb 7, 2024
@avious00 avious00 moved this to In Progress in Hyperlane Tasks Feb 7, 2024
@daniel-savu daniel-savu moved this from In Progress to In Review in Hyperlane Tasks Feb 12, 2024
daniel-savu added a commit that referenced this issue Feb 29, 2024
### Description

Implements cosmos block-by-block indexing, parallelizing where possible:
the `block` and `block_results` calls, and the individual block queries
within a range. Also reuses the existing `handle_txs` logic, to improve
readability.

### Drive-by changes

Adds `tokio::task::JoinError` to the `hyperlane-core` error enum

### Related issues

- Fixes #3234
- Added some hacky retrying logic to `get_logs_in_block`, since we were
seeing lots of `503` http errors. In
#3264 we
should make sure to remove this and propagate the error instead, to
retry via the cursor / indexer logic. I edited the description of 3264
to reflect this

### Backward compatibility

Yes

### Testing

e2e

---------

Co-authored-by: Trevor Porter <[email protected]>
@github-project-automation github-project-automation bot moved this from In Review to Done in Hyperlane Tasks Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants