Skip to content

Commit

Permalink
Different key funder job name (#3506)
Browse files Browse the repository at this point in the history
### Description

- My changes in #3491 / #3492 were kind of accurate - according to
prometheus/pushgateway#65 even using pushAdd
will displace existing metrics. It's all very confusing!
- I tested this with a script that pushed some test metrics to the push
gateway - basically by having the key funder use a different job name
than the mainnet2 one, the metrics each of them push won't conflict with
one another

### Drive-by changes

<!--
Are there any minor or drive-by changes also included?
-->

### Related issues

<!--
- Fixes #[issue number here]
-->

### Backward compatibility

<!--
Are these changes backward compatible? Are there any infrastructure
implications, e.g. changes that would prohibit deploying older commits
using this infra tooling?

Yes/No
-->

### Testing

<!--
What kind of testing have these changes undergone?

None/Manual/Unit Tests
-->
  • Loading branch information
tkporter authored Apr 2, 2024
1 parent 2093fe4 commit 9b06f3b
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion typescript/infra/config/environments/mainnet3/funding.ts
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import { environment } from './chains';
export const keyFunderConfig: KeyFunderConfig = {
docker: {
repo: 'gcr.io/abacus-labs-dev/hyperlane-monorepo',
tag: '7781bce-20240326-173938',
tag: 'd94cc52-20240328-104504',
},
// We're currently using the same deployer/key funder key as mainnet2.
// To minimize nonce clobbering we offset the key funder cron
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -238,7 +238,7 @@ async function main() {
failureOccurred ||= await funder.fund();
}

await submitMetrics(metricsRegister, 'key-funder');
await submitMetrics(metricsRegister, `key-funder-${environment}`);

if (failureOccurred) {
logger.error('At least one failure occurred when funding');
Expand Down

0 comments on commit 9b06f3b

Please sign in to comment.