Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Fix warnings #1434

Merged
merged 3 commits into from
Jul 24, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/CI.yml
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ jobs:
tool: [email protected]
- uses: hecrj/setup-rust-action@v1
with:
rust-version: "1.60"
rust-version: "1.63"
- uses: Swatinem/rust-cache@v2
- name: cargo doc
run: cargo doc --workspace --no-deps --exclude examples
Expand All @@ -102,7 +102,7 @@ jobs:
uses: actions/checkout@v3
- uses: hecrj/setup-rust-action@v1
with:
rust-version: "1.60"
rust-version: "1.63"
- name: Install protoc
uses: taiki-e/install-action@v2
with:
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ For IntelliJ IDEA users, please refer to [this](https://github.com/intellij-rust

### Rust Version

`tonic`'s MSRV is `1.60`.
`tonic`'s MSRV is `1.63`.

```bash
$ rustup update
Expand Down
2 changes: 2 additions & 0 deletions deny.toml
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,8 @@ skip-tree = [
{ name = "hermit-abi" },
{ name = "base64" },
{ name = "syn" },
{ name = "bitflags" },
{ name = "webpki-roots" },
]

[licenses]
Expand Down
3 changes: 1 addition & 2 deletions tonic/src/codec/prost.rs
Original file line number Diff line number Diff line change
Expand Up @@ -329,9 +329,8 @@ mod tests {
#[allow(clippy::drop_ref)]
fn poll_trailers(
self: Pin<&mut Self>,
cx: &mut Context<'_>,
_cx: &mut Context<'_>,
) -> Poll<Result<Option<http::HeaderMap>, Self::Error>> {
drop(cx);
Poll::Ready(Ok(None))
}
}
Expand Down
2 changes: 1 addition & 1 deletion tonic/src/transport/service/tls.rs
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ impl TlsConnector {
let mut config = match identity {
Some(identity) => {
let (client_cert, client_key) = rustls_keys::load_identity(identity)?;
builder.with_single_cert(client_cert, client_key)?
builder.with_client_auth_cert(client_cert, client_key)?
}
None => builder.with_no_client_auth(),
};
Expand Down
Loading