Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(http1): send error on Incoming body when connection errors #3256

Merged
merged 1 commit into from
Jun 19, 2023

Conversation

seanmonstar
Copy link
Member

If a connection has any error besides reading, a streaming body sometimes wouldn't be notified. This change makes it so that when a connection task is closing because of any error, an existing body channel is also notified.

Closes #3253

If a connection has any error besides reading, a streaming body
sometimes wouldn't be notified. This change makes it so that when a
connection task is closing because of any error, an existing body
channel is also notified.
@seanmonstar seanmonstar merged commit 52f1925 into master Jun 19, 2023
@seanmonstar seanmonstar deleted the conn-error-should-notify-body-channel branch June 19, 2023 18:31
seanmonstar added a commit that referenced this pull request Jun 19, 2023
If a connection has any error besides reading, a streaming body
sometimes wouldn't be notified. This change makes it so that when a
connection task is closing because of any error, an existing body
channel is also notified.

Closes #3253
seanmonstar added a commit that referenced this pull request Jun 19, 2023
If a connection has any error besides reading, a streaming body
sometimes wouldn't be notified. This change makes it so that when a
connection task is closing because of any error, an existing body
channel is also notified.

Closes #3253
seanmonstar added a commit that referenced this pull request Jun 20, 2023
If a connection has any error besides reading, a streaming body
sometimes wouldn't be notified. This change makes it so that when a
connection task is closing because of any error, an existing body
channel is also notified.

Closes #3253
0xE282B0 pushed a commit to 0xE282B0/hyper that referenced this pull request Jan 12, 2024
…ium#3256)

If a connection has any error besides reading, a streaming body
sometimes wouldn't be notified. This change makes it so that when a
connection task is closing because of any error, an existing body
channel is also notified.

Closes hyperium#3253
0xE282B0 pushed a commit to 0xE282B0/hyper that referenced this pull request Jan 16, 2024
…ium#3256)

If a connection has any error besides reading, a streaming body
sometimes wouldn't be notified. This change makes it so that when a
connection task is closing because of any error, an existing body
channel is also notified.

Closes hyperium#3253

Signed-off-by: Sven Pfennig <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing error when reading stream of data out of an interrupted chunked-encoded request
1 participant