Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename body to recv temporarily #2966

Merged
merged 1 commit into from
Aug 26, 2022
Merged

Rename body to recv temporarily #2966

merged 1 commit into from
Aug 26, 2022

Conversation

Michael-J-Ward
Copy link
Contributor

Resolves #2963

This currently branches off of #2961

@seanmonstar
Copy link
Member

How easy would it be to separate it from the other PR? I suspect this one could merge faster.

@Michael-J-Ward
Copy link
Contributor Author

I did pop off the commit, I also rebased off of master.

on master, this is failing to compile and test.
RUSTFLAGS='--cfg hyper_unstable_ffi' cargo test --all-features --all

@Michael-J-Ward
Copy link
Contributor Author

(forgot to apply cargo fmt, apologies)

@seanmonstar
Copy link
Member

Looks like the last piece remaining is to remove the link to Body in the documentation. We'll have a docs pass later on.

@Michael-J-Ward
rename body to recv temporarily
c21eebc 
"""
We'll eventually want to bikshed the name Recv, but to free up the name Body for hyperium#2839, this can be done quickly.
"""

Resolve hyperium#2963
seanmonstar
seanmonstar approved these changes Aug 26, 2022
View reviewed changes
Copy link
Member

@seanmonstar seanmonstar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you!

@seanmonstar seanmonstar merged commit 7a41da5 into hyperium:master Aug 26, 2022
RajivTS added a commit to RajivTS/hyper that referenced this pull request Aug 28, 2022
@RajivTS
refactor(body): rename HttpBody export to Body
0552706 
Now that the concrete `Body` type has been temporarily replaced with `Recv` in hyperium#2966,
we can rename and export `http_body::Body` as just `Body` instead of `HttpBody`.

Closes hyperium#2839
@RajivTS RajivTS mentioned this pull request Aug 28, 2022
Merged
RajivTS added a commit to RajivTS/hyper that referenced this pull request Aug 29, 2022
@RajivTS
refactor(body): rename HttpBody export to Body
9be9fb7 
Now that the concrete `Body` type has been temporarily replaced with `Recv` in hyperium#2966,
we can rename and export `http_body::Body` as just `Body` instead of `HttpBody`.

Closes hyperium#2839
seanmonstar pushed a commit to RajivTS/hyper that referenced this pull request Aug 29, 2022
@RajivTS @seanmonstar
refactor(body): rename HttpBody export to Body
b2a8b3d 
Now that the concrete `Body` type has been temporarily replaced with `Recv` in hyperium#2966,
we can rename and export `http_body::Body` as just `Body` instead of `HttpBody`.

Closes hyperium#2839
seanmonstar pushed a commit that referenced this pull request Aug 30, 2022
@RajivTS
fest(body): rename HttpBody export to Body (#2969)
031454e 
Now that the concrete `Body` type has been temporarily replaced with `Recv` in #2966,
we can rename and export `http_body::Body` as just `Body` instead of `HttpBody`.

Closes #2839

BREAKING CHANGE: The trait has been renamed.
@seanmonstar seanmonstar mentioned this pull request Aug 30, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seanmonstar seanmonstar seanmonstar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rename Body to Recv temporarily
2 participants
@Michael-J-Ward @seanmonstar