Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(spmc): update spmc dependency 0.2 -> 0.3 as 0.2 has been yanked #1913

Merged
merged 1 commit into from
Aug 22, 2019

Conversation

GabrielGanne
Copy link

Hi,

This should allow using rust on rust stable release channel:

  • the master branch uses the async feature which is not yet available
  • the latest released branch (0.12.x) depends on spmc and has the issue I'm trying to fix

All the changes proposed in here are taken from the master branch.
I tried to only take the minimal necessary changes.

Best regards

spmc 0.2.3 has been yanked on 2019-08-15

Passing to 0.2 requires a small change in the tests.
Changing the following (as was done in master branch)
  &'a spmc::Sender<Reply> -> &'a Mutex<spmc::Sender<Reply>>

This fixes the cargo issue telling us that he cannot handle smpc:
  error: failed to select a version for the requirement `spmc = "^0.2"`

Signed-off-by: Gabriel Ganne <[email protected]>
Copy link
Member

@seanmonstar seanmonstar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@seanmonstar seanmonstar merged commit a1609fb into hyperium:0.12.x Aug 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants