feat(server): add http1_half_close(bool) option
#1723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanmonstar
force-pushed
the
server-half-close
branch
from
8deb402 to
ff055a8
Compare
|
LGTM, let me try to test it on the broker example. |
|
Works as expected. One suggestion: can we surface it through the index a0e0b01..4bcd618 100644
--- a/src/server/mod.rs
+++ b/src/server/mod.rs
@@ -280,6 +280,14 @@ impl<I, E> Builder<I, E> {
self
}
+ /// Set whether half-closed connections are considered open.
+ ///
+ /// Default is `true`.
+ pub fn http1_half_close(mut self, val: bool) -> Self {
+ self.protocol.http1_half_close(val);
+ self
+ }
+ |
seanmonstar
force-pushed
the
server-half-close
branch
from
ff055a8 to
8c8c1f4
Compare
|
Yep, we can do that! |
luben
reviewed
Nov 27, 2018
src/proto/h1/conn.rs
Outdated
| @@ -117,7 +122,7 @@ where I: AsyncRead + AsyncWrite, | |||
|
|
|||
| fn should_error_on_eof(&self) -> bool { | |||
| // If we're idle, it's probably just the connection closing gracefully. | |||
| T::should_error_on_parse_eof() && !self.state.is_idle() | |||
| !self.state.is_idle() | |||
There was a problem hiding this comment.
This fixes (with returning back the should_error_on_parse_eof()) the failing empty_parse_eof_does_not_return_error but I am not sure it's the right approach:
(T::should_error_on_parse_eof() || !self.state.allow_half_close) && !self.state.is_idle()This option determines whether a read EOF should close the connection automatically. The behavior was to always allow read EOF while waiting to respond, so this option has a default of `true`. Setting this option to `false` will allow Service futures to be canceled as soon as disconnect is noticed. Closes #1716
seanmonstar
force-pushed
the
server-half-close
branch
from
8c8c1f4 to
afd5ed7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This option determines whether a read EOF should close the connection
automatically. The behavior was to always allow read EOF while waiting
to respond, so this option has a default of
true.Setting this option to
falsewill allow Service futures to be canceledas soon as disconnect is noticed.
Closes #1716
cc @luben