feat(server): Creating Server with a Handle WIP #1332
Conversation
There was a problem hiding this comment.
Great start!
I believe the code inside run_until can be moved to impl Future for Server, and then run_until can convert the Server from one that ones a Core to one that owns a Handle from that same core, and just calls core.run(server). (Of course, still a panic if the Server didn't have a Core).
| @@ -389,7 +416,10 @@ impl<S, B> Server<S, B> | |||
| /// Returns a handle to the underlying event loop that this server will be | |||
| /// running on. | |||
| pub fn handle(&self) -> Handle { | |||
| self.core.handle() | |||
| match self.internal { | |||
| ServerInternal::Core(ref core) => core.handle().clone(), | |||
There was a problem hiding this comment.
The clone here isn't need, core.handle() already returns Handle.
| where S: NewService<Request = Request, Response = Response<Bd>, Error = ::Error> + 'static, | ||
| Bd: Stream<Item=B, Error=::Error>, | ||
| { | ||
| let listener = TcpListener::bind(addr, &handle).unwrap(); |
There was a problem hiding this comment.
This probably means bind_handle should return a Result, just like bind does, so that we don't panic.
|
Master has grown to have a Thanks for taking a stab at this! |
This PR is a work-in-progress for #1322.