Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No way to use a custom TLS wrapper for proxy connections #824

Closed
inejge opened this issue Jun 12, 2016 · 1 comment
Closed

No way to use a custom TLS wrapper for proxy connections #824

inejge opened this issue Jun 12, 2016 · 1 comment

Comments

@inejge
Copy link

inejge commented Jun 12, 2016

[Motivation: rust-lang/rustup#509]

The function client::Client::with_http_proxy constructs a Proxy struct (via hyper::client::proxy::tunnel) with the ssl field which depends on build-time configuration of the TLS library. Rustup compiles hyper with no TLS support, using its own TLS wrapper based on rust-native-tls. In this case, hyper will use the built-in no_ssl::Plaintext wrapper, which will preclude using https URLs with proxy support.

There is currently no way to specify a custom TLS wrapper when initializing a proxied Client.
inejge added a commit to inejge/hyper that referenced this issue Jun 12, 2016
@inejge
feat(client): enable use of custom TLS wrapper for proxied connections
452a87d 
The new struct ProxyConfig lets one specify a custom TLS wrapper for
proxied connections. The function Client::with_proxy_config takes an
instance of that struct and returns an appropriately initialized new
Client. The connector for talking to the proxy is still fixed to
HttpConnector.

Fixes hyperium#824
inejge added a commit to inejge/hyper that referenced this issue Jun 12, 2016
@inejge
feat(client): enable use of custom TLS wrapper for proxied connections
0476196 
The new struct ProxyConfig lets one specify a custom TLS wrapper for
proxied connections. The function Client::with_proxy_config takes an
instance of that struct and returns an appropriately initialized new
Client. The connector for talking to the proxy is still fixed to
HttpConnector.

Fixes hyperium#824
@inejge inejge mentioned this issue Jun 12, 2016
Merged
@seanmonstar
Copy link
Member

seanmonstar commented Jun 14, 2016 •
edited
Loading

I've merged the accompanying PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@seanmonstar @inejge