Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change Client to keep connector as a Box<NetworkConnector> #379

Closed
seanmonstar opened this issue Mar 17, 2015 · 1 comment · Fixed by #428
Closed

change Client to keep connector as a Box<NetworkConnector> #379

seanmonstar opened this issue Mar 17, 2015 · 1 comment · Fixed by #428
Labels
A-client Area: client. E-easy Effort: easy. A task that would be a great starting point for a new contributor.

Comments

@seanmonstar
Copy link
Member

This removes the generics from Client, letting people use a Client easily without caring what connecting and streaming business is going on underneath.
@seanmonstar seanmonstar added A-client Area: client. E-easy Effort: easy. A task that would be a great starting point for a new contributor. labels Mar 17, 2015
@reem
Copy link
Contributor

reem commented Mar 17, 2015

cc #346

seanmonstar added a commit that referenced this issue Apr 4, 2015
@seanmonstar
feat(client): remove generic parameter for Connector
139a51f 
Closes #379

BREAKING CHANGE: For people using the default HttpConnector and Client,
    everything should continue to just work. If the Client has been
    used with a generic parameter, it should be removed.

    However, there were some breaking changes to the internals of
    NetworkConnectors. Specifically, they no longer return a
    NetworkStream, but instead a Into<Box<NetworkStream + Send>>. All
    implementations of NetworkStream should continue to just work,
    however.

    Possible breakages could come from the stricter usage of Send
    throughout the Client API.
@seanmonstar seanmonstar mentioned this issue Apr 4, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-client Area: client. E-easy Effort: easy. A task that would be a great starting point for a new contributor.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(client): remove generic parameter for Connector hyperium/hyper
2 participants
@seanmonstar @reem