Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the combined-version server Connection type #3012

Closed
seanmonstar opened this issue Oct 13, 2022 · 0 comments · Fixed by #3013
Closed

Remove the combined-version server Connection type #3012

seanmonstar opened this issue Oct 13, 2022 · 0 comments · Fixed by #3013
Assignees
@seanmonstar
Labels
A-server Area: server. C-feature Category: feature. This is adding a new feature. E-medium Effort: medium. Some knowledge of how hyper internal works would be useful.
Milestone
1.0 RC1

Comments

@seanmonstar
Copy link
Member

With #2851 complete, we now have separate types for HTTP/1 and HTTP/2 server connections. We'll remove the combo server::conn::{Http, Connection} stuff for 1.0. A combined/auto type can live in hyper-util.
@seanmonstar seanmonstar added A-server Area: server. C-feature Category: feature. This is adding a new feature. E-medium Effort: medium. Some knowledge of how hyper internal works would be useful. labels Oct 13, 2022
@seanmonstar seanmonstar added this to the 1.0 RC1 milestone Oct 13, 2022
@seanmonstar seanmonstar moved this to In Progress in hyper 1.0 Oct 13, 2022
@seanmonstar seanmonstar self-assigned this Oct 13, 2022
@seanmonstar seanmonstar mentioned this issue Oct 14, 2022
Merged
Repository owner moved this from In Progress to Done in hyper 1.0 Oct 17, 2022
seanmonstar added a commit that referenced this issue Oct 17, 2022
@seanmonstar
feat(server): remove server::conn::{Http, Connection} types (#3013)
0766d3f 
The connection types have been split into version-specific types, in the
`server::conn::{http1, http2}` modules.

Closes #3012

BREAKING CHANGE: Either choose a version-specific `Connection` type, or
  look for the auto-version type in `hyper-util`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@seanmonstar seanmonstar

Labels
A-server Area: server. C-feature Category: feature. This is adding a new feature. E-medium Effort: medium. Some knowledge of how hyper internal works would be useful.
Projects
No open projects
hyper 1.0
Status: Done
Milestone
1.0 RC1
Development

Successfully merging a pull request may close this issue.

feat(server): remove server::conn::{Http, Connection} types hyperium/hyper
1 participant
@seanmonstar