Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make body::Sender type and Body::channel() constructor private. #2962

Closed
Tracked by #2345
seanmonstar opened this issue Aug 25, 2022 · 1 comment · Fixed by #2970
Closed
Tracked by #2345

Make body::Sender type and Body::channel() constructor private. #2962

seanmonstar opened this issue Aug 25, 2022 · 1 comment · Fixed by #2970
Assignees
@oddgrd
Labels
A-body Area: body streaming. C-feature Category: feature. This is adding a new feature. E-easy Effort: easy. A task that would be a great starting point for a new contributor.
Milestone
1.0 RC1

Comments

@seanmonstar
Copy link
Member

seanmonstar commented Aug 25, 2022 •
edited
Loading

This is an "easy" task, in that the changes aren't complicated:

  • Change the hyper::body::Sender type to pub(crate).
  • Change the Body::channel() method to pub(crate).
  • Replace any usage in the examples, tests, or docs with an appropriate alternative.
    • This might be as simple as a Full, but if specifically showing a channel usage, or needing a channel behavior for a test, a tokio::sync::mpsc wrapped in StreamBody should work.
@seanmonstar seanmonstar mentioned this issue Aug 25, 2022
Closed
8 tasks
@seanmonstar seanmonstar added E-easy Effort: easy. A task that would be a great starting point for a new contributor. C-feature Category: feature. This is adding a new feature. A-body Area: body streaming. labels Aug 25, 2022
@seanmonstar seanmonstar added this to the 1.0 RC1 milestone Aug 25, 2022
@oddgrd
Copy link
Contributor

oddgrd commented Aug 25, 2022

I'll get started on this.

@oddgrd oddgrd mentioned this issue Aug 29, 2022
Merged
seanmonstar pushed a commit that referenced this issue Aug 29, 2022
@oddgrd
feat(body): make body::Sender and Body::channel private (#2970)
d963e6a 
Closes #2962 

BREAKING CHANGE: A channel body will be available in `hyper-util`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oddgrd oddgrd

Labels
A-body Area: body streaming. C-feature Category: feature. This is adding a new feature. E-easy Effort: easy. A task that would be a great starting point for a new contributor.
Projects
No open projects
hyper 1.0
Status: Done
Milestone
1.0 RC1
Development

Successfully merging a pull request may close this issue.

feat: make body::Sender and Body::channel private oddgrd/hyper
2 participants
@seanmonstar @oddgrd